Skip to content

benchmark timeout when benchtime set too long #49974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

lkxiaolou
Copy link

@lkxiaolou lkxiaolou commented Dec 4, 2021

When benchmark function execute time is very short, set benchtime=5s / 10s / 20s is ok.

BenchmarkNewObject-2            1000000000               0.279 ns/op

But set benchtime=120s will execute time out.

*** Test killed with quit: ran too long (11m0s).

image

  1. benchtime short
    The B.n maybe 1 , 100 , 10000, 1000000, 100000000, 100000000 and exist.

  2. benchtime long
    But set benchtime=120s, n = goalns * prevIters / prevns may be overflow(< 0) int64, and the B.n maybe 1, 100, 10000, 1000000, 100000000, 100000001, 100000002 .... and timeout.

@google-cla google-cla bot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Dec 4, 2021
@lkxiaolou lkxiaolou changed the title Fix #49973 benchmark timeout when benchtime set too long #49950 Fix #49973 benchmark timeout when benchtime set too long Dec 4, 2021
@gopherbot
Copy link
Contributor

This PR (HEAD: b535c98) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/369294 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://golang.org/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/369294.
After addressing review feedback, remember to publish your drafts!

1. handles overflows
2. add an unit test
1. handles overflows
2. add an unit test
@google-cla google-cla bot added cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change. and removed cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. labels Dec 7, 2021
@lkxiaolou lkxiaolou changed the title Fix #49973 benchmark timeout when benchtime set too long benchmark timeout when benchtime set too long Dec 7, 2021
@lkxiaolou lkxiaolou closed this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Used by googlebot to label PRs as having an invalid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants