cmd/cgo: fix unaligned arguments typedmemmove crash on iOS #53064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

timcooijmans wants to merge 1 commit into golang:master from timcooijmans:feature/fix-unaligned-arguments

Contributor

timcooijmans commented May 25, 2022

Irregularly typedmemmove and bulkBarrierPreWrite crashes on
unaligned arguments. By aligning the arguments on 8 bytes this
is fixed.

Fixes #46893


          cmd/cgo: fix unaligned arguments typedmemmove crash on iOS

f0cb9ff

Irregularly typedmemmove and bulkBarrierPreWrite crashes on
unaligned arguments. By aligning the arguments on 8 bytes this
is fixed.

Fixes golang#46893

Contributor

gopherbot commented May 25, 2022

This PR (HEAD: f0cb9ff) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/408395 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Contributor

gopherbot commented May 25, 2022

Message from Changkun Ou:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 25, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 25, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 26, 2022

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 26, 2022

Message from Tim Cooijmans:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 26, 2022

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented May 26, 2022

Message from Cherry Mui:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 2, 2022

Message from Tim Cooijmans:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 3, 2022

Message from Eric Lagergren:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Jun 3, 2022

Message from Eric Lagergren:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Changkun Ou:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Tim Cooijmans:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Cherry Mui:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Tim Cooijmans:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Eric Lagergren:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Sep 25, 2023

Message from Eric Lagergren:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/408395.
After addressing review feedback, remember to publish your drafts!

seankhliao closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet