runtime: mark string comparison hooks as no split #53544
Conversation
|
This PR (HEAD: 3294aa2) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/413978 to see it. Tip: You can toggle comments from me using the |
|
Message from Dmitri Shuralyov: Patch Set 1: Run-TryBot+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Dmitri Shuralyov: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
These functions can be inserted by the compiler into the code to be instrumented. This may result in these functions having callers that are nosplit. That is why they must be nosplit. This is a followup for CL 410034 in order to fix golang#53190.
kyakdan
force-pushed
the
mark-string-compare-callbacks-as-noplit
branch
from
3294aa2 to
6506d86
Compare
|
This PR (HEAD: 6506d86) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/413978 to see it. Tip: You can toggle comments from me using the |
|
Message from Khaled Yakdan: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Dmitri Shuralyov: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Keith Randall: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Khaled Yakdan: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Dmitri Shuralyov: Patch Set 3: Run-TryBot+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Gopher Robot: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
|
Message from Gopher Robot: Patch Set 3: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/413978. |
These functions can be inserted by the compiler into the code to be instrumented. This may result in these functions having callers that are nosplit. That is why they must be nosplit. This is a followup for CL 410034 in order to fix #53190. Change-Id: I03746208a2a302a581a1eaad6c9d0672bb1e949a GitHub-Last-Rev: 6506d86 GitHub-Pull-Request: #53544 Reviewed-on: https://go-review.googlesource.com/c/go/+/413978 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
|
This PR is being closed because golang.org/cl/413978 has been merged. |
These functions can be inserted by the compiler into the code to be instrumented. This may result in these functions having callers that are nosplit. That is why they must be nosplit. This is a followup for CL 410034 in order to fix golang#53190. Change-Id: I03746208a2a302a581a1eaad6c9d0672bb1e949a GitHub-Last-Rev: 6506d86 GitHub-Pull-Request: golang#53544 Reviewed-on: https://go-review.googlesource.com/c/go/+/413978 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Dmitri Shuralyov <[email protected]>
These functions can be inserted by the compiler into the code to be
instrumented. This may result in these functions having callers that
are nosplit. That is why they must be nosplit.
This is a followup for CL 410034 in order to fix #53190.