net: fix LookupNetIP to return IPv4 addresses instead of IPv4 in IPv6 #53555

kasparjarek · 2022-06-26T09:40:38Z

The method is currently just a wrapper around the old way. But the old way
represents IPv4 in 16 bytes slice, so when this wrapper parses the slice it
will always create an IPv6 address. For IPv4 addresses, it's IPv4 in IPv6.
The fix converts the old IPv4 address representation to 4 bytes slice
before parsing, so it's parsed as IPv4 and not IPv4 in IPv6.

Fixes #53554

The method is currently just a wrapper around the old way. But the old way represents IPv4 in 16 bytes slice, so when this wrapper parses the slice it will always create IPv6 address. For IPv4 addreses it's IPv4 in IPv6. The fix just converts the old IPv4 address representation to 4 bytes slice before parsing, so it's parsed as IPv4 and not IPv4 in IPv6. Fixes golang#53554

google-cla · 2022-06-26T09:40:42Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

gopherbot · 2022-06-26T09:50:05Z

This PR (HEAD: 5b84e0a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/414275 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2022-06-26T09:53:55Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.