Skip to content

time: adjust time zone offset if desired location differs mere seconds when parsing string #53920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

time: adjust time zone offset if desired location differs mere seconds when parsing string #53920

wants to merge 3 commits into from

Conversation

MarkRosemaker
Copy link

This PR aims to fix an issue where a time.Time object was seconds off after having been converted into a string using Format with RFC3339 and back using ParseInLocation.

For illustration, a copy of the test that was added to this PR.
https://go.dev/play/p/5t8wa3b_ahv

Fixes #53919

@MarkRosemaker MarkRosemaker marked this pull request as ready for review July 16, 2022 17:17
@gopherbot
Copy link
Contributor

This PR (HEAD: 8874c8c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/417934 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1: Hold+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/417934.
After addressing review feedback, remember to publish your drafts!

Copy link

@lgrachov lgrachov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all files are cool!

@gopherbot
Copy link
Contributor

This PR (HEAD: 6f8e945) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/417934 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/417934 has been abandoned.

Thanks, but we aren't doing this.

@gopherbot gopherbot closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

time: ParseInLocation does not adjust timezone offset when seconds are not explicitly set
3 participants