-
Notifications
You must be signed in to change notification settings - Fork 18k
net/http: fix when writeLoop exited still has request in writech #57403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When there is still a request in writech after writeLoop exits, the request body will not be closed and will not be retried. The request is not sent to the server, so it can be safely retried without regard to idempotence. Fixes golang#49621
This PR (HEAD: e8cc45e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/458437 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/458437. |
This PR (HEAD: cc2bf9e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/458437 to see it. Tip: You can toggle comments from me using the |
This PR (HEAD: 922d323) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/458437 to see it. Tip: You can toggle comments from me using the |
Message from Damien Neil: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/458437. |
This PR (HEAD: a1b6c50) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/458437 to see it. Tip: You can toggle comments from me using the |
Message from aoang lona: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/458437. |
Message from aoang lona: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/458437. |
Message from Damien Neil: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/458437. |
Message from aoang lona: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/458437. |
When there is still a request in writech after
writeLoop exits, the request body will not be
closed and will not be retried.
The request is not sent to the server, so it can
be safely retried without regard to idempotence.
Fixes #49621