-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/compile/internal/staticinit: fix panic in interface conversion #58389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: aa72769) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/466175 to see it. Tip: You can toggle comments from me using the |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Robert Griesemer: Patch Set 1: Code-Review+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Gopher Robot: Patch Set 1: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Matthew Dempsky: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
This PR (HEAD: 82b7452) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/466175 to see it. Tip: You can toggle comments from me using the |
Message from Sung Whang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Matthew Dempsky: Patch Set 2: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
This PR (HEAD: f6b2620) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/466175 to see it. Tip: You can toggle comments from me using the |
Message from Cuong Manh Le: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Sung Whang: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
This PR (HEAD: 834bbf5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/466175 to see it. Tip: You can toggle comments from me using the |
Message from Sung Whang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Cuong Manh Le: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Gopher Robot: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Gopher Robot: Patch Set 4: TryBot-Result+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Matthew Dempsky: Patch Set 4: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Sung Whang: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
This PR (HEAD: 05c089f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/466175 to see it. Tip: You can toggle comments from me using the |
This patch fixes a panic from incorrect interface conversion from *ir.BasicLit to *ir.ConstExpr. This only occurs when nounified GOEXPERIMENT is set, so ideally it should be backported to Go 1.20 and removed from master. Fixes golang#58339
Message from Matthew Dempsky: Patch Set 5: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
This PR (HEAD: 641dedb) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/466175 to see it. Tip: You can toggle comments from me using the |
Message from Sung Whang: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Cuong Manh Le: Patch Set 6: Auto-Submit+1 Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Cuong Manh Le: Patch Set 6: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
Message from Gopher Robot: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/466175. |
This patch fixes a panic from incorrect interface conversion from *ir.BasicLit to *ir.ConstExpr. This only occurs when nounified GOEXPERIMENT is set, so ideally it should be backported to Go 1.20 and removed from master. Fixes #58339 Change-Id: I357069d7ee1707d5cc6811bd2fbdd7b0456323ae GitHub-Last-Rev: 641dedb GitHub-Pull-Request: #58389 Reviewed-on: https://go-review.googlesource.com/c/go/+/466175 Reviewed-by: Matthew Dempsky <[email protected]> Run-TryBot: Cuong Manh Le <[email protected]> Reviewed-by: Cuong Manh Le <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Robert Griesemer <[email protected]>
This PR is being closed because golang.org/cl/466175 has been merged. |
This patch fixes a panic from incorrect interface conversion from *ir.BasicLit to *ir.ConstExpr. This only occurs when nounified GOEXPERIMENT is set, so ideally it should be backported to Go 1.20 and removed from master. Fixes golang#58339 Change-Id: I357069d7ee1707d5cc6811bd2fbdd7b0456323ae GitHub-Last-Rev: 641dedb GitHub-Pull-Request: golang#58389 Reviewed-on: https://go-review.googlesource.com/c/go/+/466175 Reviewed-by: Matthew Dempsky <[email protected]> Run-TryBot: Cuong Manh Le <[email protected]> Reviewed-by: Cuong Manh Le <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Robert Griesemer <[email protected]>
This patch fixes a panic from incorrect interface conversion from
*ir.BasicLit to *ir.ConstExpr. This only occurs when nounified
GOEXPERIMENT is set, so ideally it should be backported to Go
1.20 and removed from master.
Fixes #58339