Skip to content

slices: add a CloneFunc function #58865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

slices: add a CloneFunc function #58865

wants to merge 1 commit into from

Conversation

shoenig
Copy link
Contributor

@shoenig shoenig commented Mar 4, 2023

A CloneFunc function solves 2 situations I encounter regularly.

  1. Creating a deep copy of a slice
    Many structs have something like ".Copy" or ".Clone" or ".DeepCopy" to implement a deep copy mechanism. CloneFunc enables using the slices package to make a copy of slices of such structs by leaving the copy implementation up to the caller.

  2. Creating a transposition of a slice
    Often we'll have a struct of one type and wish to create a slice of another type based on the first one. For example, creating a string slice of just the ".Name" field from a slice of complex Person structs. CloneFunc enables the caller to provide just the conversion method when creating the new slice.

A CloneFunc function solves 2 situations I encounter regularly.

1. Creating a deep copy of a slice
  Many structs have something like ".Copy" or ".Clone" or ".DeepCopy"
  to implement a deep copy mechanism. CloneFunc enables using the slices
  package to make a copy of slices of such structs by leaving the copy
  implementation up to the caller.

2. Creating a transposition of a slice
  Often we'll have a struct of one type and wish to create a slice of
  another type based on the first one. For example, creating a string
  slice of just the ".Name" field from a slice of complex Person structs.
  CloneFunc enables the caller to provide just the conversion method when
  creaing the new slice.
@gopherbot
Copy link
Contributor

This PR (HEAD: 08f6c06) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/473456 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/473456.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/473456.
After addressing review feedback, remember to publish your drafts!

@shoenig shoenig closed this by deleting the head repository Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants