[release-branch.go1.21] runtime: fix Pinner.Pin documentation #64920

qiulaidongfeng · 2024-01-01T09:01:39Z

Fixes #63768

gopherbot · 2024-01-01T09:05:44Z

This PR (HEAD: 7371fc7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553395.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-01T09:12:12Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T09:18:32Z

Message from [email protected]:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T09:31:17Z

Message from qiulaidongfeng:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T09:37:32Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T09:37:33Z

Message from Gopher Robot:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T09:50:00Z

Message from Gopher Robot:

Patch Set 2: TryBot-Result-1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-01T09:50:01Z

Message from qiulaidongfeng:

Patch Set 2: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-02T14:28:40Z

Message from qiulaidongfeng:

Patch Set 2: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-06T07:25:32Z

This PR (HEAD: 8ab1972) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553395.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-06T07:31:49Z

Message from qiulaidongfeng:

Patch Set 3: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-06T07:38:12Z

Message from Gopher Robot:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-06T07:50:27Z

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-06T07:50:27Z

Message from qiulaidongfeng:

Patch Set 3: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T17:37:48Z

Message from Cherry Mui:

Patch Set 3: Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T17:37:49Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-25T17:28:14Z","revision":"4923c960bc487608d5dd3e728667b4357361120b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T17:44:58Z

Message from Cherry Mui:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T17:44:59Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/go1.21-linux-amd64-staticlockranking has failed with summary (view all results):

FAILURE

go on release-branch.go1.21 (change 553395)

Tests failed. See all test results.

Error:
shard 1: failed to run "go tool dist test -json": exit status 1
shard 2: failed to run "go tool dist test -json": exit status 1

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T17:45:00Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T17:52:24Z

Message from Cherry Mui:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-25T19:47:29Z

Message from Michael Knyszek:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

Fixes golang#63768

Change-Id: I287cb3a6c80f05237fbea1fb81c69c1c584abad3

gopherbot · 2024-01-26T00:47:10Z

This PR (HEAD: 7c5dd4e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/553395.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-01-26T00:53:19Z

Message from qiulaidongfeng:

Patch Set 4: Run-TryBot+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-26T00:59:56Z

Message from Gopher Robot:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-26T01:12:12Z

Message from Gopher Robot:

Patch Set 4: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-26T01:12:13Z

Message from qiulaidongfeng:

Patch Set 4: -Run-TryBot

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T17:46:27Z

Message from Michael Knyszek:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T17:46:28Z

Message from Michael Knyszek:

Patch Set 4: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T18:05:27Z

Message from Cherry Mui:

Patch Set 4: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T21:03:12Z

Message from Michael Knyszek:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-01-31T21:09:24Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-01-31T20:54:26Z","revision":"6712e822cf6d6edc91c4b1496ac9cb9e56ca46a9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/553395.
After addressing review feedback, remember to publish your drafts!

Fixes #63768 Change-Id: I01a9bb8f9af22a6b3f6534d431e3ea623875ed48 GitHub-Last-Rev: 7c5dd4e GitHub-Pull-Request: #64920 Reviewed-on: https://go-review.googlesource.com/c/go/+/553395 Reviewed-by: Michael Knyszek <[email protected]> Auto-Submit: Michael Knyszek <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> TryBot-Result: Gopher Robot <[email protected]>

gopherbot · 2024-01-31T21:28:40Z

This PR is being closed because golang.org/cl/553395 has been merged.

qiulaidongfeng changed the title ~~[release-branch.go1.21] runtime: fix Pinner.Pin documention~~ [release-branch.go1.21] runtime: fix Pinner.Pin documentation Jan 1, 2024

qiulaidongfeng force-pushed the 63768 branch from 7371fc7 to 8ab1972 Compare January 6, 2024 07:24

This was referenced Jan 20, 2024

x/pkgsite: slow to download std when running locally #60114

Open

proposal: x/tools/{godoc,cmd/godoc}: isolate, tag, and delete godoc #59056

Closed

qiulaidongfeng added 2 commits January 26, 2024 08:39

[release-branch.go1.21] runtime: fix Pinner.Pin documention

206a65c

Fixes golang#63768

[release-branch.go1.21] fix

7c5dd4e

Change-Id: I287cb3a6c80f05237fbea1fb81c69c1c584abad3

qiulaidongfeng force-pushed the 63768 branch from 8ab1972 to 7c5dd4e Compare January 26, 2024 00:45

gopherbot closed this Jan 31, 2024

gabyhelp mentioned this pull request Nov 24, 2025

runtime: documentation update for Pinner #76431

Closed

[release-branch.go1.21] runtime: fix Pinner.Pin documentation #64920

[release-branch.go1.21] runtime: fix Pinner.Pin documentation #64920

Uh oh!

Conversation

qiulaidongfeng commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 1, 2024

Uh oh!

gopherbot commented Jan 2, 2024

Uh oh!

gopherbot commented Jan 6, 2024

Uh oh!

gopherbot commented Jan 6, 2024

Uh oh!

gopherbot commented Jan 6, 2024

Uh oh!

gopherbot commented Jan 6, 2024

Uh oh!

gopherbot commented Jan 6, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 25, 2024

Uh oh!

gopherbot commented Jan 26, 2024

Uh oh!

gopherbot commented Jan 26, 2024

Uh oh!

gopherbot commented Jan 26, 2024

Uh oh!

gopherbot commented Jan 26, 2024

Uh oh!

gopherbot commented Jan 26, 2024

Uh oh!

gopherbot commented Jan 31, 2024

Uh oh!

gopherbot commented Jan 31, 2024

Uh oh!

gopherbot commented Jan 31, 2024

Uh oh!

gopherbot commented Jan 31, 2024

Uh oh!

gopherbot commented Jan 31, 2024

Uh oh!

gopherbot commented Jan 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants