-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/cgo: fix unaligned arguments typedmemmove crash on iOS #66296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cgo: fix unaligned arguments typedmemmove crash on iOS #66296
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: 2c343ad) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571375. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/571375. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/571375. |
Message from Luke Plaster: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/571375. |
Message from Ian Lance Taylor: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/571375. |
On iOS arm64, irregular typedmemmove and bulkBarrierPreWrite crashes on unaligned arguments. By aligning the arguments on `PtrSize` bytes this is fixed. The included test attempts to reproduce with golang#46893 (comment). Fixes golang#46893
2c343ad
to
7f2e4a7
Compare
This PR (HEAD: 7f2e4a7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571375. Important tips:
|
Message from Luke Plaster: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/571375. |
Message from Ian Lance Taylor: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/571375. |
This PR (HEAD: 5587479) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571375. Important tips:
|
On iOS arm64, irregular typedmemmove and bulkBarrierPreWrite crashes on unaligned arguments. By aligning the arguments on `PtrSize` bytes this is fixed. Original source: golang#66296
On iOS arm64, Irregular typedmemmove and bulkBarrierPreWrite crashes
on unaligned arguments. By aligning the arguments on
PtrSize
bytesthis is fixed.
The included test attempts to reproduce with
#46893 (comment).
Fixes #46893