cmd/preprofile: correct -V flag #66949

And-ZJ · 2024-04-21T11:21:39Z

No description provided.

gopherbot · 2024-04-21T11:25:31Z

This PR (HEAD: 8041411) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-21T11:31:37Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-21T11:51:29Z

Message from J Z:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-01T15:37:27Z

This PR (HEAD: cb0cb8a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-13T15:52:56Z

This PR (HEAD: 4c63a74) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-06T01:58:17Z

This PR (HEAD: 86f2064) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-21T11:06:42Z

This PR (HEAD: eb27f2a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-07T13:56:30Z

This PR (HEAD: 439b1fd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T01:26:46Z

Message from qiu laidongfeng2:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T01:33:00Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-08T01:21:57Z","revision":"c5016a8c6c1aa9ddb653b34e8b24065374a30d6b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T01:45:31Z

Message from qiu laidongfeng2:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T01:45:31Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T01:51:48Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T02:11:06Z

Message from qiu laidongfeng2:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-25T16:21:13Z

This PR (HEAD: 1b12626) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-26T11:56:57Z

Message from qiu laidongfeng2:

Patch Set 7: Code-Review+1 Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T11:56:57Z

Message from Gopher Robot:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T12:04:21Z

Message from Gopher Robot:

Patch Set 7: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T14:05:48Z

Message from qiu laidongfeng2:

Patch Set 7: -Run-TryBot Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T14:05:49Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-26T13:58:12Z","revision":"23fab59b07b6c0e619f32429b727530e54a24898"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T14:29:48Z

Message from qiu laidongfeng2:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T14:29:49Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-26T14:29:49Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-24T16:01:26Z

This PR (HEAD: cc56931) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-24T16:09:10Z

Message from J Z:

Patch Set 7:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-25T16:10:15Z

Message from Cherry Mui:

Patch Set 8: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-25T16:10:15Z

Message from Go LUCI:

Patch Set 8:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-25T16:01:37Z","revision":"b8f0eda964f122401f7e0d66bb76e3def60e1af9"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-25T16:33:42Z

Message from Cherry Mui:

Patch Set 8: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-25T16:33:42Z

Message from Go LUCI:

Patch Set 8:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-25T16:33:43Z

Message from Go LUCI:

Patch Set 8: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T16:35:54Z

This PR (HEAD: d1fa4e5) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580615.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-11-27T16:44:41Z

Message from J Z:

Patch Set 9:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T18:00:36Z

Message from Cherry Mui:

Patch Set 9: Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T18:00:36Z

Message from Go LUCI:

Patch Set 9:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-11-27T17:52:11Z","revision":"c2ccaef4b3d7eb7d8a3817c33aaa4545e8430518"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T18:24:54Z

Message from Cherry Mui:

Patch Set 9: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T18:24:54Z

Message from Go LUCI:

Patch Set 9:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T18:24:55Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-11-27T19:07:02Z

Message from Veronica Silina:

Patch Set 9: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/580615.
After addressing review feedback, remember to publish your drafts!

Change-Id: I9a0dc3a4b4c81f0f6942badcd4643a74c5046440 GitHub-Last-Rev: d1fa4e5 GitHub-Pull-Request: #66949 Reviewed-on: https://go-review.googlesource.com/c/go/+/580615 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: qiu laidongfeng2 <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Veronica Silina <[email protected]>

gopherbot · 2024-11-27T21:33:42Z

This PR is being closed because golang.org/cl/580615 has been merged.

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from 8041411 to cb0cb8a Compare May 1, 2024 15:34

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from cb0cb8a to 4c63a74 Compare June 13, 2024 15:47

And-ZJ changed the title ~~cmd/preprofile: remove deleted -v flag and gofmt~~ cmd/preprofile: remove deleted -v flag Jun 13, 2024

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from 4c63a74 to 86f2064 Compare July 6, 2024 01:54

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from 86f2064 to eb27f2a Compare July 21, 2024 11:00

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from eb27f2a to 439b1fd Compare September 7, 2024 13:52

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from 439b1fd to 1b12626 Compare September 25, 2024 16:20

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from 1b12626 to cc56931 Compare November 24, 2024 15:57

cmd/preprofile: correct -V flag

d1fa4e5

And-ZJ force-pushed the And-ZJ-patch-preprofile branch from cc56931 to d1fa4e5 Compare November 27, 2024 16:32

And-ZJ changed the title ~~cmd/preprofile: remove deleted -v flag~~ cmd/preprofile: correct -V flag Nov 27, 2024

gopherbot closed this Nov 27, 2024

cmd/preprofile: correct -V flag #66949

cmd/preprofile: correct -V flag #66949

Conversation

And-ZJ commented Apr 21, 2024

gopherbot commented Apr 21, 2024

gopherbot commented Apr 21, 2024

gopherbot commented Apr 21, 2024

gopherbot commented May 1, 2024

gopherbot commented Jun 13, 2024

gopherbot commented Jul 6, 2024

gopherbot commented Jul 21, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 25, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Sep 26, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 24, 2024

gopherbot commented Nov 25, 2024

gopherbot commented Nov 25, 2024

gopherbot commented Nov 25, 2024

gopherbot commented Nov 25, 2024

gopherbot commented Nov 25, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024

gopherbot commented Nov 27, 2024