-
Notifications
You must be signed in to change notification settings - Fork 18k
internal/byteorder: new package #67183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: fc9410d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
This PR (HEAD: b04e715) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-05T15:09:42Z","revision":"f39788bc5ed75af6838d97faefbf5abdf7a64955"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Mateusz Poliwczak: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
This PR (HEAD: 20209f4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-05T15:13:43Z","revision":"083b5aeef058669e88323ddab48498021d5a24e3"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Hang Jiang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
This PR (HEAD: 0325169) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
This PR (HEAD: 84a1d8c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
This PR (HEAD: ff66442) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 6: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 6: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-05T16:17:19Z","revision":"f5bcb7666c1906e2748c6e6b84d6c9a20d0878f9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Mateusz Poliwczak: Patch Set 6: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 6: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error:
Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 6: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
This PR (HEAD: 85f4802) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Ian Lance Taylor: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
This PR (HEAD: 276c63a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
246cafb
to
c572c81
Compare
This PR (HEAD: c572c81) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Ian Lance Taylor: Patch Set 9: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
8885b68
to
c572c81
Compare
Change-Id: I78f392576c8516b9bcdd79e1f828ce4012e8cbbd
Change-Id: Ia9d87edac709cf68250a699040fbbdce0476d978
Change-Id: I118d26201e38cd94f38ec20ee859438b6d78a46e
Change-Id: I688ffeeeb9eb47a0a7002d2c89a098e1ed2de6cd
9c3d850
to
3f07d3d
Compare
This PR (HEAD: 3f07d3d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/583298. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 18: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 18: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-10T06:08:22Z","revision":"d3dd1a6effe65ef4cca595042d64f6525b50c4cf"} Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Mateusz Poliwczak: Patch Set 18: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 18: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Go LUCI: Patch Set 18: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Message from Cherry Mui: Patch Set 18: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/583298. |
Currently in a lot of packages we define functions for appending/decoding mostly BigEndian data (see internal/chacha8rand, net/netip, internal/boring/sha, hash/crc64, and probably more), because we don't want to depend on encoding/binary, because of #54097. This change introduces a new package internal/byteorder, that will allow us to remove all of the functions and replace them with internal/byteorder. Updates #54097 Change-Id: I03e5ea1eb721dd98bdabdb25786f889cc5de54c5 GitHub-Last-Rev: 3f07d3d GitHub-Pull-Request: #67183 Reviewed-on: https://go-review.googlesource.com/c/go/+/583298 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]>
This PR is being closed because golang.org/cl/583298 has been merged. |
Currently in a lot of packages we define functions for appending/decoding mostly BigEndian data (see internal/chacha8rand, net/netip, internal/boring/sha, hash/crc64, and probably more), because we don't want to depend on encoding/binary, because of #54097. This change introduces a new package internal/byteorder, that will allow us to remove all of the functions and replace them with internal/byteorder. Updates #54097 Change-Id: I03e5ea1eb721dd98bdabdb25786f889cc5de54c5 GitHub-Last-Rev: 3f07d3dfb453a9e679395711f9b93e25f9340a3b GitHub-Pull-Request: golang/go#67183 Reviewed-on: https://go-review.googlesource.com/c/go/+/583298 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]>
Currently in a lot of packages we define functions for appending/decoding mostly BigEndian data (see internal/chacha8rand, net/netip, internal/boring/sha, hash/crc64, and probably more), because we don't want to depend on encoding/binary, because of #54097. This change introduces a new package internal/byteorder, that will allow us to remove all of the functions and replace them with internal/byteorder. Updates #54097 Change-Id: I03e5ea1eb721dd98bdabdb25786f889cc5de54c5 GitHub-Last-Rev: 3f07d3dfb453a9e679395711f9b93e25f9340a3b GitHub-Pull-Request: golang/go#67183 Reviewed-on: https://go-review.googlesource.com/c/go/+/583298 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]>
Currently in a lot of packages we define functions for appending/decoding mostly BigEndian data (see internal/chacha8rand, net/netip, internal/boring/sha, hash/crc64, and probably more), because we don't want to depend on encoding/binary, because of #54097. This change introduces a new package internal/byteorder, that will allow us to remove all of the functions and replace them with internal/byteorder. Updates #54097 Change-Id: I03e5ea1eb721dd98bdabdb25786f889cc5de54c5 GitHub-Last-Rev: 3f07d3dfb453a9e679395711f9b93e25f9340a3b GitHub-Pull-Request: golang/go#67183 Reviewed-on: https://go-review.googlesource.com/c/go/+/583298 Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]>
Currently in a lot of packages we define functions for appending/decoding
mostly BigEndian data (see internal/chacha8rand, net/netip,
internal/boring/sha, hash/crc64, and probably more), because we don't
want to depend on encoding/binary, because of #54097.
This change introduces a new package internal/byteorder, that
will allow us to remove all of the functions and replace them with
internal/byteorder.
Updates #54097