-
Notifications
You must be signed in to change notification settings - Fork 18k
net/netip: use internal/byteorder #67317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also as a side effect fixes golang#56136 because internal/netip-use-byteorder package has a special treatment in the inliner. Fixes golang#56136 Change-Id: I113185207186c3fa780240de009192096d3c77a6
This PR (HEAD: a78d8f6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/584995. Important tips:
|
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-11T05:33:43Z","revision":"3c6fe6608d20bd348a0fac0af71a74b0adac05af"} Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Mateusz Poliwczak: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Ian Lance Taylor: Patch Set 1: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-05-12T05:25:36Z","revision":"3c6fe6608d20bd348a0fac0af71a74b0adac05af"} Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Ian Lance Taylor: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
This also as a side effect fixes #56136 because internal/byteorder package has a special treatment in the inliner. Fixes #56136 Change-Id: Ib90eb716f7a67659fb4cea7e99c14cf7e819ef7b GitHub-Last-Rev: a78d8f6 GitHub-Pull-Request: #67317 Reviewed-on: https://go-review.googlesource.com/c/go/+/584995 Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Damien Neil <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Tobias Klauser <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
Message from Tobias Klauser: Patch Set 1: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/584995. |
This PR is being closed because golang.org/cl/584995 has been merged. |
This also as a side effect fixes #56136 because internal/byteorder
package has a special treatment in the inliner.
Fixes #56136