text/template: support range-over-func #68329

qiulaidongfeng · 2024-07-07T09:18:59Z

For #66107

gopherbot · 2024-07-07T09:22:58Z

This PR (HEAD: fcb7d02) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-07T09:29:10Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:29:18Z

This PR (HEAD: de7bd47) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-07T09:41:06Z

Message from qiu laidongfeng2:

Patch Set 1: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:41:07Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-07-07T09:23:40Z","revision":"42a8707463d5ff9f1a9bb048621262def7dbd115"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:41:07Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:41:07Z

Message from qiu laidongfeng2:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:41:08Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-07-07T09:30:13Z","revision":"03248f1368cd261342116f8147b833775aad56bc"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:58:44Z

Message from qiu laidongfeng2:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:58:45Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T09:58:45Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-07T15:36:35Z

Message from Ian Lance Taylor:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-08T12:26:58Z

This PR (HEAD: 22a9730) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-07-08T12:40:43Z

Message from qiu laidongfeng2:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-08T12:47:50Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-07-08T12:31:21Z","revision":"409ff49b8dc014f04d9886eca5d843bcc70dee93"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-08T13:01:09Z

Message from qiu laidongfeng2:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-08T13:01:10Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-08T13:01:10Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-16T00:30:54Z

Message from Russ Cox:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-07-19T04:32:54Z

Message from qiu laidongfeng2:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T07:28:35Z

Message from qiu laidongfeng2:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T03:44:45Z

Message from Ian Lance Taylor:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

Fixes golang#66107 Change-Id: If3e503efca200aa86463c9d27d06986b03c0d638

Change-Id: If16c21bd933e22f55afe85f6aaf0891cd9a40ef9

Change-Id: Id67b97c88504a8c6ef9cb6702217f3dd170eca2a

Change-Id: I219e28bb3dd32f91573803481dcda2828453987b

gopherbot · 2024-09-08T04:38:15Z

This PR (HEAD: 2a119ee) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Change-Id: I1775584dd31aa431585f268b4d6c28497a82614a

gopherbot · 2024-09-08T05:09:52Z

This PR (HEAD: 3d9e2e7) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-17T03:08:18Z

Message from Go LUCI:

Patch Set 11: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T03:08:26Z

This PR (HEAD: fd4a8c2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-17T03:30:16Z

Message from qiu laidongfeng2:

Patch Set 12: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T03:30:17Z

Message from Go LUCI:

Patch Set 12:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-17T03:23:58Z","revision":"efeddd0ca0b5b9ddc356dae5b1b9d742454da4c4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T03:58:19Z

Message from qiu laidongfeng2:

Patch Set 12: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T03:58:19Z

Message from Go LUCI:

Patch Set 12:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T03:58:19Z

Message from Go LUCI:

Patch Set 12: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-18T21:43:35Z

Message from Ian Lance Taylor:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

Change-Id: I8ed2b28225874104f9e78f66d3f2f4018bac81af

gopherbot · 2024-09-19T11:35:24Z

This PR (HEAD: 6470379) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Change-Id: I23ea3f7a59567f00dfb8b58d4bd067230fe94e13

gopherbot · 2024-09-19T13:45:18Z

This PR (HEAD: 5ebf615) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/596956.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-19T13:52:54Z

Message from qiu laidongfeng2:

Patch Set 14: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T13:52:54Z

Message from Go LUCI:

Patch Set 14:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-19T13:36:21Z","revision":"c45e34c9403882fbd95c71763aaeb85d8060628e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T13:52:55Z

Message from qiu laidongfeng2:

Patch Set 14: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T13:52:55Z

Message from Go LUCI:

Patch Set 14: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T13:52:56Z

Message from qiu laidongfeng2:

Patch Set 15: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T13:52:57Z

Message from Go LUCI:

Patch Set 15:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-19T13:48:41Z","revision":"67294f0edea4f6c478a1c6e4cac0674582bc6b1e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T14:15:47Z

Message from qiu laidongfeng2:

Patch Set 15: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T14:15:47Z

Message from Go LUCI:

Patch Set 15:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T14:15:48Z

Message from Go LUCI:

Patch Set 15: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-19T23:56:08Z

Message from Ian Lance Taylor:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T00:02:44Z

Message from qiu laidongfeng2:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T23:06:13Z

Message from Ian Lance Taylor:

Patch Set 15: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T23:12:48Z

Message from Go LUCI:

Patch Set 15:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-20T22:58:27Z","revision":"67294f0edea4f6c478a1c6e4cac0674582bc6b1e"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T23:19:28Z

Message from Ian Lance Taylor:

Patch Set 15: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-20T23:19:29Z

Message from Go LUCI:

Patch Set 15:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/596956.
After addressing review feedback, remember to publish your drafts!

For #66107 Change-Id: I2fcd04bebe80346dbd244ab7ea09cbe6010b9d8e GitHub-Last-Rev: 5ebf615 GitHub-Pull-Request: #68329 Reviewed-on: https://go-review.googlesource.com/c/go/+/596956 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]>

gopherbot · 2024-09-23T14:47:20Z

This PR is being closed because golang.org/cl/596956 has been merged.

qiulaidongfeng added 4 commits September 8, 2024 12:00

text/template: support range-over-func

845bc01

Fixes golang#66107 Change-Id: If3e503efca200aa86463c9d27d06986b03c0d638

doc

e5c75ea

Change-Id: If16c21bd933e22f55afe85f6aaf0891cd9a40ef9

doc

797456b

Change-Id: Id67b97c88504a8c6ef9cb6702217f3dd170eca2a

new

2a119ee

Change-Id: I219e28bb3dd32f91573803481dcda2828453987b

qiulaidongfeng force-pushed the 66107 branch from 22a9730 to 2a119ee Compare September 8, 2024 04:32

new

3d9e2e7

Change-Id: I1775584dd31aa431585f268b4d6c28497a82614a

new

6470379

Change-Id: I8ed2b28225874104f9e78f66d3f2f4018bac81af

new

5ebf615

Change-Id: I23ea3f7a59567f00dfb8b58d4bd067230fe94e13

gopherbot closed this Sep 23, 2024

text/template: support range-over-func #68329

text/template: support range-over-func #68329

Conversation

qiulaidongfeng commented Jul 7, 2024 • edited Loading

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 7, 2024

gopherbot commented Jul 8, 2024

gopherbot commented Jul 8, 2024

gopherbot commented Jul 8, 2024

gopherbot commented Jul 8, 2024

gopherbot commented Jul 8, 2024

gopherbot commented Jul 8, 2024

gopherbot commented Jul 16, 2024

gopherbot commented Jul 19, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 18, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 19, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 20, 2024

gopherbot commented Sep 23, 2024

qiulaidongfeng commented Jul 7, 2024 •

edited

Loading