-
Notifications
You must be signed in to change notification settings - Fork 18k
misc/wasm: move wasm runtime files to lib/wasm #68840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: c033927) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: fcd2241) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Dmitri Shuralyov: Patch Set 2: Commit-Queue+1 (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-12T13:05:07Z","revision":"d71a07f5aac158c4a79460ac10f5853c6c6f075c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Dmitri Shuralyov: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-wasip1-wasm_wazero has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging:
Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 9afa97b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Zxilly Chou: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Dmitri Shuralyov: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Johan Brandhorst-Satzkorn: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Zxilly Chou: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 25ff50c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Dmitri Shuralyov: Patch Set 4: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: bb86099) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: d7c8657) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Johan Brandhorst-Satzkorn: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 5676260) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Zxilly Chou: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Johan Brandhorst-Satzkorn: Patch Set 7: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 9825c86) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 7: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Dmitri Shuralyov: Patch Set 8: Code-Review+2 Commit-Queue+1 (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Johan Brandhorst-Satzkorn: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 1ece807) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Cherry Mui: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Zxilly Chou: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 9d921ed) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
This PR (HEAD: dff93a7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Zxilly Chou: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: cad0954) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Cherry Mui: Patch Set 19: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Dmitri Shuralyov: Patch Set 19: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Zxilly Chou: Patch Set 19: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR (HEAD: 4242f36) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/604696. Important tips:
|
Message from Dmitri Shuralyov: Patch Set 20: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Go LUCI: Patch Set 20: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-30T17:59:39Z","revision":"b7bea45edf980c511efaa408c8b9d97f1b70f2c9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Cherry Mui: Patch Set 20: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Dmitri Shuralyov: Patch Set 20: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Go LUCI: Patch Set 20: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Message from Go LUCI: Patch Set 20: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
Fixes #68024 Change-Id: I730c3ecfb14472f3eea3895c2a4d5e1d4ac146f5 GitHub-Last-Rev: 4242f36 GitHub-Pull-Request: #68840 Reviewed-on: https://go-review.googlesource.com/c/go/+/604696 Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Johan Brandhorst-Satzkorn <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>
Message from Dmitri Shuralyov: Patch Set 20: Auto-Submit+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/604696. |
This PR is being closed because golang.org/cl/604696 has been merged. |
Fixes #68024