-
Notifications
You must be signed in to change notification settings - Fork 18k
hash/maphash: add WriteComparable and Comparable #69166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: f4f4514) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
This PR (HEAD: 7fad797) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
This PR (HEAD: 9fc6340) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
This PR (HEAD: d4dcce9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
By default, runtime.memhash is used. When purego is used, reflect is used to generate the same []byte with the same value, and then hash the []byte. Fixes golang#54670 Change-Id: Ibd0538a7dfb3d831c5145970cac7c910692bca69
This PR (HEAD: 02df413) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from Ingo Oeser: Patch Set 5: (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: 7668494) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
This PR (HEAD: d498867) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from Ingo Oeser: Patch Set 8: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: 1ce6954) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from Keith Randall: Patch Set 11: (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: 10f0778) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from qiu laidongfeng2: Patch Set 12: Commit-Queue+1 (19 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 12: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-07T07:15:15Z","revision":"5a7d8b32bcbfc07c80fdc5760f7a306190a18306"} Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from qiu laidongfeng2: Patch Set 12: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 12: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 12: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: 6a2db95) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from qiu laidongfeng2: Patch Set 13: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: f4ae01e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from qiu laidongfeng2: Patch Set 16: Commit-Queue+1 (7 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 16: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-19T13:37:56Z","revision":"44d94bdf1fee799f88c6b1fc0c3fb96718f84c56"} Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from qiu laidongfeng2: Patch Set 16: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 16: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 16: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Keith Randall: Patch Set 16: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: d73a7a5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from qiu laidongfeng2: Patch Set 17: Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 17: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-24T13:39:13Z","revision":"b52bca6e009e91035307177b5afb6b9399f5af69"} Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from qiu laidongfeng2: Patch Set 17: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 17: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 17: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Keith Randall: Patch Set 17: Code-Review+2 (9 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
This PR (HEAD: 5ae8a28) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609761. Important tips:
|
Message from qiu laidongfeng2: Patch Set 19: Commit-Queue+1 (8 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 19: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-25T12:55:18Z","revision":"0a3a360fafff811fce93f0407359f1a83b6c7ca7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from qiu laidongfeng2: Patch Set 19: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 19: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Go LUCI: Patch Set 19: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from Keith Randall: Patch Set 19: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Message from David Chase: Patch Set 19: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/609761. |
Default, use hash function in the runtime package. If the build tag is purego or raw memory cannot be hash directly, use reflect get each field to hash separately. Fixes #54670 Change-Id: Ic968864c9c3c51883967d4f6dc24432385c7dc79 GitHub-Last-Rev: 5ae8a28 GitHub-Pull-Request: #69166 Reviewed-on: https://go-review.googlesource.com/c/go/+/609761 Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Keith Randall <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: David Chase <[email protected]>
This PR is being closed because golang.org/cl/609761 has been merged. |
Default, use hash function in the runtime package.
If the build tag is purego or raw memory cannot be hash directly,
use reflect get each field to hash separately.
Fixes #54670