cmd/dist: enforce the lowest bootstrap version #69168

qiulaidongfeng · 2024-08-30T14:09:01Z

The go1.24 release notes say that go1.22.6 is the
minimum bootstraps required,
the go team also use go1.22.6 bootstraps in testing,
so if there's a problem with using an older version,
automated testing won't uncover it.

Now enforce this in dist to avoid
release notes that do not match reality, which can be confusing.

For #64751

The go1.24 release notes say that go1.22.6 is the minimum bootstraps required, the go team also use go1.22.6 bootstraps in testing, so if there's a problem with using an older version, automated testing won't uncover it. Now enforce this in dist to avoid release notes that do not match reality, which can be confusing. For golang#64751 Change-Id: I8d50770e19f7f014e1316f0ac872e288a27c20fe

gopherbot · 2024-08-30T14:15:24Z

This PR (HEAD: afeed52) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-07T07:28:47Z

Message from qiu laidongfeng2:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T07:35:17Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-07T07:21:32Z","revision":"c8297b91644a58b836d3d69ab116e6336f62d40d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T07:35:18Z

Message from qiu laidongfeng2:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T07:35:18Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-arm64-boringcrypto has failed with summary (view all results):

go on master (change 609762)

Build or test failure, click here for results.

To reproduce, try gomote repro 8737472721416922017.

Additional links for debugging:

Output for make.bash [shard 1]

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T07:35:19Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

Change-Id: I412bac099822116d691ef73159e3625de501a0cd

gopherbot · 2024-09-07T07:48:46Z

This PR (HEAD: c2cea55) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-07T08:03:07Z

Message from qiu laidongfeng2:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T08:03:08Z

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-07T07:51:32Z","revision":"403376642266ef0137d1de49a260b67b1a34e260"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T08:23:27Z

Message from qiu laidongfeng2:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T08:23:28Z

Message from Go LUCI:

Patch Set 2:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T08:23:28Z

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

Change-Id: Iab695472bee8188ce6b0b21894b0e18badb2ab4e

gopherbot · 2024-09-07T14:41:49Z

This PR (HEAD: ea5c927) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-07T14:55:05Z

Message from qiu laidongfeng2:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T14:55:05Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-07T14:42:50Z","revision":"7385d157d69f4a395c1941c342cbddf9c5345ede"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T15:15:33Z

Message from qiu laidongfeng2:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T15:15:34Z

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-07T15:15:34Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T03:58:24Z

Message from Ian Lance Taylor:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

Change-Id: I888c0c8d3d7614547b53938c5440894b84a75cbe

gopherbot · 2024-09-08T04:05:26Z

This PR (HEAD: d574061) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T04:18:34Z

Message from qiu laidongfeng2:

Patch Set 4: Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T04:18:35Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-08T04:07:15Z","revision":"3a8b1d9299dea1b29a03b34493b643fdd2a0792f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T04:18:35Z

Message from Ian Lance Taylor:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T04:31:31Z

Message from Ian Lance Taylor:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T04:31:31Z

Message from qiu laidongfeng2:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T04:31:32Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T04:31:32Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T05:29:59Z

Message from Dmitri Shuralyov:

Patch Set 4:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

Change-Id: I8f97788fd8a4edb24c44c8e9976039945fb242ec

gopherbot · 2024-09-08T05:43:38Z

This PR (HEAD: 9287edb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Change-Id: I6ebafdbf5e056600571cae4a7271c58622e844c8

gopherbot · 2024-09-08T05:50:26Z

Message from Dmitri Shuralyov:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T05:50:34Z

This PR (HEAD: 63e038d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T06:04:51Z

Message from qiu laidongfeng2:

Patch Set 6: Commit-Queue+1

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T06:04:52Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-08T05:51:22Z","revision":"27e6e5b0163d6f05861d87a4259473fba089c88f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T06:25:07Z

Message from qiu laidongfeng2:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T06:25:08Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T06:25:08Z

Message from Go LUCI:

Patch Set 6: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T15:03:44Z

Message from Ian Lance Taylor:

Patch Set 6: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T15:10:26Z

Message from Go LUCI:

Patch Set 6:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-08T14:57:16Z","revision":"27e6e5b0163d6f05861d87a4259473fba089c88f"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T15:23:13Z

Message from Ian Lance Taylor:

Patch Set 6: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T15:23:14Z

Message from Go LUCI:

Patch Set 6:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-17T14:02:10Z

Message from qiu laidongfeng2:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-23T21:58:16Z

Message from Dmitri Shuralyov:

Patch Set 6: Code-Review+2

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-23T21:58:16Z

Message from Dmitri Shuralyov:

Patch Set 6: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

Change-Id: I54dc17eb3d3d978d28f7e7be0bc8f94ed5b75adf

gopherbot · 2024-09-24T12:53:26Z

This PR (HEAD: 425cd7f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/609762.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-24T13:25:09Z

Message from Dmitri Shuralyov:

Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-24T13:25:09Z

Message from Go LUCI:

Patch Set 7:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-24T13:01:17Z","revision":"143ab346f629922997ae9a651afff7ed06e79b73"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-24T13:44:16Z

Message from Dmitri Shuralyov:

Patch Set 7: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-24T13:44:16Z

Message from Go LUCI:

Patch Set 7:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-24T13:44:17Z

Message from Go LUCI:

Patch Set 7: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/609762.
After addressing review feedback, remember to publish your drafts!

The go1.24 release notes say that go1.22.6 is the minimum bootstraps required, the go team also use go1.22.6 bootstraps in testing, so if there's a problem with using an older version, automated testing won't uncover it. Now enforce this in dist to avoid release notes that do not match reality, which can be confusing. For #64751 Change-Id: Icd2f8a47b2bbb2d7c3dab9be9a228f43b9630063 GitHub-Last-Rev: 425cd7f GitHub-Pull-Request: #69168 Reviewed-on: https://go-review.googlesource.com/c/go/+/609762 Reviewed-by: David Chase <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]>

gopherbot · 2024-09-26T13:27:29Z

This PR is being closed because golang.org/cl/609762 has been merged.

new

c2cea55

Change-Id: I412bac099822116d691ef73159e3625de501a0cd

new

ea5c927

Change-Id: Iab695472bee8188ce6b0b21894b0e18badb2ab4e

new

d574061

Change-Id: I888c0c8d3d7614547b53938c5440894b84a75cbe

new

9287edb

Change-Id: I8f97788fd8a4edb24c44c8e9976039945fb242ec

new

63e038d

Change-Id: I6ebafdbf5e056600571cae4a7271c58622e844c8

new

425cd7f

Change-Id: I54dc17eb3d3d978d28f7e7be0bc8f94ed5b75adf

gopherbot closed this Sep 26, 2024

cmd/dist: enforce the lowest bootstrap version #69168

cmd/dist: enforce the lowest bootstrap version #69168

Conversation

qiulaidongfeng commented Aug 30, 2024

gopherbot commented Aug 30, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 7, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 17, 2024

gopherbot commented Sep 23, 2024

gopherbot commented Sep 23, 2024

gopherbot commented Sep 24, 2024

gopherbot commented Sep 24, 2024

gopherbot commented Sep 24, 2024

gopherbot commented Sep 24, 2024

gopherbot commented Sep 24, 2024

gopherbot commented Sep 24, 2024

gopherbot commented Sep 26, 2024