go/printer: check whether !isTypeElem, instead of combinesWithName when ParenExpr#69309
go/printer: check whether !isTypeElem, instead of combinesWithName when ParenExpr#69309mateusz834 wants to merge 2 commits into
Conversation
|
This PR (HEAD: 7dda2f5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611355. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Mateusz Poliwczak: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Mateusz Poliwczak: Patch Set 1: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-06T09:19:48Z","revision":"13a75dcf8bbcd1aad36d2cd73c531969f4721bb1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Copied votes on follow-up patch sets have been updated:
Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-06T09:21:09Z","revision":"e5b1710b8610bc608a8807a55c9e60434c5754f9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Mateusz Poliwczak: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-06T09:25:41Z","revision":"e5b1710b8610bc608a8807a55c9e60434c5754f9"} Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Mateusz Poliwczak: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
This PR (HEAD: 37993b5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611355. Important tips:
|
|
Message from Robert Griesemer: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-06T18:58:39Z","revision":"a3a495ca2ca9dfd5bee1768876b1bc76eac08304"} Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Robert Griesemer: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
…en ParenExpr See discussion in CL 610115 and CL 610758. For #69206 Change-Id: I16f394cb3440106650fb64a466f2723a4dba3871 GitHub-Last-Rev: 37993b5 GitHub-Pull-Request: #69309 Reviewed-on: https://go-review.googlesource.com/c/go/+/611355 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com>
|
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611355. |
|
This PR is being closed because golang.org/cl/611355 has been merged. |
…en ParenExpr See discussion in CL 610115 and CL 610758. For #69206 Change-Id: I16f394cb3440106650fb64a466f2723a4dba3871 GitHub-Last-Rev: 37993b5baf11f83e8fb9428981965f2d964cddf3 GitHub-Pull-Request: golang/go#69309 Reviewed-on: https://go-review.googlesource.com/c/go/+/611355 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com>
See discussion in CL 610115 and CL 610758.
For #69206