cmd/go: cache coverage profile with tests #69339

ryancurrah · 2024-09-07T23:50:36Z

This CL stores coverage profile data in the GOCACHE under the
'coverprofile' subkey alongside tests. This makes tests which use
coverage profiles cacheable. The values of the -coverprofile and
-outputdir flags are not included in the cache key to allow cached
profile data to be written to any output file.

Note: This is a rebase and squash from the original PRs below that
was created/closed/abandoned by @jproberts and @macnibblet that I
plan to maintain.

I made improvements to the change based on feedback from @bcmills in Gerrit
https://go-review.googlesource.com/c/go/+/563138.

From @macnibblet:

I don't know if anyone has considered the environmental impact
(Yes, of course, dev experience too), but on a team with 3 backend
developers, when I replaced our CI Golang version with this build,
it reduced the build time by 50%, which would have
equated to about 5000 hours of CI reduced in the past year.

Fixes #23565

gopherbot · 2024-09-07T23:54:53Z

This PR (HEAD: cdd481a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T00:01:47Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T00:08:50Z

This PR (HEAD: bd314f3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T00:22:32Z

This PR (HEAD: 233e83d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T01:21:04Z

Message from Ryan Currah:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T02:17:56Z

Message from qiu laidongfeng2:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T02:24:14Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-08T02:10:10Z","revision":"b17804a47a2c088d0306e906e58bbfd8fc4b0c60"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T02:30:29Z

Message from qiu laidongfeng2:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T02:30:29Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-386 has failed with summary (view all results):

go on master (change 610564)

Build or test failure, click here for results.

To reproduce, try gomote repro 8737401713837560897.

Additional links for debugging:

Output for go tool dist test -json [shard 3]

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T02:30:30Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-08T18:44:18Z

This PR (HEAD: 69990a8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T19:20:10Z

This PR (HEAD: 9b4a15c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T19:27:01Z

This PR (HEAD: bf6ed10) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-08T19:33:27Z

Message from Ryan Currah:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-09T14:52:47Z

Message from Than McIntosh:

Patch Set 6:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-09T23:02:25Z

Message from Ryan Currah:

Patch Set 6:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-09-09T23:02:34Z

This PR (HEAD: 171ab52) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-09-16T12:24:12Z

This PR (HEAD: a75bc4d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-12-08T16:12:10Z

This PR (HEAD: 6de06a9) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-01-25T19:54:36Z

Message from Ryan Currah:

Patch Set 12:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-25T20:03:14Z

This PR (HEAD: 0cd6a8c) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-01-25T20:52:09Z

This PR (HEAD: b960982) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

… profile cache data

gopherbot · 2025-01-25T21:07:26Z

This PR (HEAD: a3c9197) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-01-30T03:40:05Z

Message from علي نور:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-30T03:47:38Z

Message from علي نور:

Patch Set 15: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-01-30T04:22:39Z

Message from علي نور:

Patch Set 15:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-21T17:16:31Z

Message from Than McIntosh:

Patch Set 15: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-02-25T15:52:01Z

This PR (HEAD: a5a1d1b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/610564.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2025-03-03T22:09:37Z

Message from Michael Matloob:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T02:58:49Z

Message from Ryan Currah:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T16:00:33Z

Message from Michael Matloob:

Patch Set 16: Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T16:00:34Z

Message from Michael Matloob:

Patch Set 16: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T16:00:35Z

Message from Gopher Robot:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T20:36:35Z

Message from Michael Matloob:

Patch Set 16: -Run-TryBot Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T20:44:00Z

Message from Go LUCI:

Patch Set 16:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-03-05T20:27:28Z","revision":"bc0ae3e5f0c1c4edb982f256029214b23debff00"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T21:05:51Z

Message from Michael Matloob:

Patch Set 16: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T21:05:52Z

Message from Go LUCI:

Patch Set 16:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T21:05:52Z

Message from Go LUCI:

Patch Set 16: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T21:05:53Z

Message from Michael Matloob:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-05T21:49:54Z

Message from Than McIntosh:

Patch Set 16: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2025-03-06T16:15:38Z

Message from Junyang Shao:

Patch Set 16: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/610564.
After addressing review feedback, remember to publish your drafts!

@jproberts

This CL stores coverage profile data in the GOCACHE under the 'coverprofile' subkey alongside tests. This makes tests which use coverage profiles cacheable. The values of the -coverprofile and -outputdir flags are not included in the cache key to allow cached profile data to be written to any output file. Note: This is a rebase and squash from the original PRs below that was created/closed/abandoned by @jproberts and @macnibblet that I plan to maintain. - #50483 - #65657 I made improvements to the change based on feedback from @bcmills in Gerrit https://go-review.googlesource.com/c/go/+/563138. From @macnibblet: I don't know if anyone has considered the environmental impact (Yes, of course, dev experience too), but on a team with 3 backend developers, when I replaced our CI Golang version with this build, it reduced the build time by 50%, which would have equated to about 5000 hours of CI reduced in the past year. Fixes #23565 Change-Id: I59a20af5ea156f990a17544cf06dc667ae7f8aa3 GitHub-Last-Rev: a5a1d1b GitHub-Pull-Request: #69339 Reviewed-on: https://go-review.googlesource.com/c/go/+/610564 Reviewed-by: Michael Matloob <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Than McIntosh <[email protected]> Reviewed-by: Junyang Shao <[email protected]>

gopherbot · 2025-03-06T16:37:41Z

This PR is being closed because golang.org/cl/610564 has been merged.

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch 2 times, most recently from 6c1e7be to cdd481a Compare September 7, 2024 23:53

ryancurrah mentioned this pull request Sep 7, 2024

cmd/go: coverage profile should be cached with tests #23565

Closed

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from cdd481a to bd314f3 Compare September 8, 2024 00:03

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from bd314f3 to 233e83d Compare September 8, 2024 00:21

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from 233e83d to 69990a8 Compare September 8, 2024 18:40

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch 2 times, most recently from dbc5e2b to 9b4a15c Compare September 8, 2024 19:16

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from 9b4a15c to bf6ed10 Compare September 8, 2024 19:24

ryancurrah mentioned this pull request Oct 23, 2024

cmd/go: enable GOCACHEPROG by default #64876

Closed

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from a75bc4d to 6de06a9 Compare December 8, 2024 16:04

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from 03a56e6 to 0cd6a8c Compare January 25, 2025 19:58

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from 0cd6a8c to b960982 Compare January 25, 2025 20:48

ensure the coverprofile flag is not empty before retrieving the cover…

a3c9197

… profile cache data

ryancurrah force-pushed the coverage-profile-should-be-cached-with-tests branch from b960982 to a3c9197 Compare January 25, 2025 21:05

Merge branch 'master' into coverage-profile-should-be-cached-with-tests

a5a1d1b

gopherbot closed this Mar 6, 2025

cmd/go: cache coverage profile with tests #69339

cmd/go: cache coverage profile with tests #69339

Conversation

ryancurrah commented Sep 7, 2024 • edited Loading

gopherbot commented Sep 7, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 8, 2024

gopherbot commented Sep 9, 2024

gopherbot commented Sep 9, 2024

gopherbot commented Sep 9, 2024

gopherbot commented Sep 16, 2024

gopherbot commented Dec 8, 2024

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 25, 2025

gopherbot commented Jan 30, 2025

gopherbot commented Jan 30, 2025

gopherbot commented Jan 30, 2025

gopherbot commented Feb 21, 2025

gopherbot commented Feb 25, 2025

gopherbot commented Mar 3, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 5, 2025

gopherbot commented Mar 6, 2025

gopherbot commented Mar 6, 2025

ryancurrah commented Sep 7, 2024 •

edited

Loading