-
Notifications
You must be signed in to change notification settings - Fork 18k
runtime: add the checkPtraceScope to skip certain tests #69933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 8b99f1a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857. Important tips:
|
Message from qiu laidongfeng2: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
This PR (HEAD: 495f91f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857. Important tips:
|
Message from Fuo Wang: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from qiu laidongfeng2: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-20T12:22:00Z","revision":"d961e93a05f9ea4f5fc79c0edc7d61b7c5fb3546"} Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from qiu laidongfeng2: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Michael Knyszek: Patch Set 2: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
This PR (HEAD: 70857cf) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857. Important tips:
|
Message from Fuo Wang: Patch Set 3: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from qiu laidongfeng2: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-22T12:17:55Z","revision":"ad256d2edfd39528835ad23e16e34438a5a7811e"} Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from qiu laidongfeng2: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Michael Knyszek: Patch Set 3: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
This PR (HEAD: 063759e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620857. Important tips:
|
Message from Fuo Wang: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Michael Knyszek: Patch Set 4: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 4: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-10-23T15:11:20Z","revision":"7a38e13f3074ec61a1bcfa3cd057a842eb49aebc"} Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Michael Knyszek: Patch Set 4: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 4: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
Message from Go LUCI: Patch Set 4: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/620857. |
When the kernel parameter ptrace_scope is set to 2 or 3, certain test cases in runtime-gdb_test.go will fail. We should skip these tests. Fixes #69932 Change-Id: I685d1217f1521d7f8801680cf6b71d8e7a265188 GitHub-Last-Rev: 063759e GitHub-Pull-Request: #69933 Reviewed-on: https://go-review.googlesource.com/c/go/+/620857 Auto-Submit: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Michael Knyszek <[email protected]>
This PR is being closed because golang.org/cl/620857 has been merged. |
When the kernel parameter ptrace_scope is set to 2 or 3,
certain test cases in runtime-gdb_test.go will fail.
We should skip these tests.
Fixes #69932