Skip to content

syscall: disable O_DIRECTORY on Windows for js/wasm #71770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

syscall: disable O_DIRECTORY on Windows for js/wasm #71770

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7b59bd
syscall: disable O_DIRECTORY on Windows for js/wasm
Zxilly Feb 15, 2025
0e22316
Update fs_js.go
Zxilly Feb 17, 2025
a0160e8
formatted
Zxilly Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions src/syscall/fs_js.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,26 @@ var constants = jsFS.Get("constants")
var uint8Array = js.Global().Get("Uint8Array")

var (
nodeWRONLY = constants.Get("O_WRONLY").Int()
nodeRDWR = constants.Get("O_RDWR").Int()
nodeCREATE = constants.Get("O_CREAT").Int()
nodeTRUNC = constants.Get("O_TRUNC").Int()
nodeAPPEND = constants.Get("O_APPEND").Int()
nodeEXCL = constants.Get("O_EXCL").Int()
nodeDIRECTORY = constants.Get("O_DIRECTORY").Int()
nodeWRONLY = constants.Get("O_WRONLY").Int()
nodeRDWR = constants.Get("O_RDWR").Int()
nodeCREATE = constants.Get("O_CREAT").Int()
nodeTRUNC = constants.Get("O_TRUNC").Int()
nodeAPPEND = constants.Get("O_APPEND").Int()
nodeEXCL = constants.Get("O_EXCL").Int()

// NodeJS on Windows does not support O_DIRECTORY, so we default
// to -1 and assign it in init if available.
// See https://nodejs.org/docs/latest/api/fs.html#file-open-constants.
nodeDIRECTORY = -1
)

func init() {
oDir := constants.Get("O_DIRECTORY")
if !oDir.IsUndefined() {
nodeDIRECTORY = oDir.Int()
}
}

type jsFile struct {
path string
entries []string
Expand Down Expand Up @@ -85,7 +96,11 @@ func Open(path string, openmode int, perm uint32) (int, error) {
return 0, errors.New("syscall.Open: O_SYNC is not supported by js/wasm")
}
if openmode&O_DIRECTORY != 0 {
flags |= nodeDIRECTORY
if nodeDIRECTORY != -1 {
flags |= nodeDIRECTORY
} else {
return 0, errors.New("syscall.Open: O_DIRECTORY is not supported on Windows")
}
}

jsFD, err := fsCall("open", path, flags, perm)
Expand Down