Skip to content

multiple: fix lock management bugs and improve error handling#77848

Open
feizaizheli wants to merge 1 commit intogolang:masterfrom
feizaizheli:fix_multiple_bugs
Open

multiple: fix lock management bugs and improve error handling#77848
feizaizheli wants to merge 1 commit intogolang:masterfrom
feizaizheli:fix_multiple_bugs

Conversation

@feizaizheli
Copy link

This commit fixes several critical bugs across multiple packages:

  1. syscall: Fix incorrect defer usage in forkpipe2.go lock management

    • acquireForkLock: Remove defer that causes double unlock when hasWaitingReaders returns true. The deferred Unlock() would execute after manual unlock/relock sequence, causing undefined behavior.
    • releaseForkLock: Unlock before panic to prevent deadlock when detecting negative forking count.
  2. encoding/json: Add defensive bounds checking in stream.go

    • Token(): Add len(tokenStack) == 0 check before accessing tokenStack[len(tokenStack)-1] for both ']' and '}' delimiters.
    • Prevents potential panic on malformed or concurrent access.
  3. syscall: Replace panic with error return in Accept4 functions

    • syscall_freebsd.go, syscall_netbsd.go, syscall_openbsd.go:
    • Change panic("RawSockaddrAny too small") to return EINVAL error.
    • Allows graceful error handling instead of crashing the program.

These fixes improve robustness in concurrent scenarios and abnormal input handling, following Go's error handling best practices.

Fixes: Lock management issues in fork operations
Fixes: Potential array bounds violations in JSON parsing
Fixes: Inappropriate panic usage in syscall package

Change-Id: Ia1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8a9b0

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

  • The PR title is formatted as follows: net/http: frob the quux before blarfing
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. ideally under 76 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at 76 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes #1234 or Updates #1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than golang/go you can use the
    owner/repo#issue_number syntax: Fixes golang/tools#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

This commit fixes several critical bugs across multiple packages:

1. syscall: Fix incorrect defer usage in forkpipe2.go lock management
   - acquireForkLock: Remove defer that causes double unlock when
     hasWaitingReaders returns true. The deferred Unlock() would execute
     after manual unlock/relock sequence, causing undefined behavior.
   - releaseForkLock: Unlock before panic to prevent deadlock when
     detecting negative forking count.

2. encoding/json: Add defensive bounds checking in stream.go
   - Token(): Add len(tokenStack) == 0 check before accessing
     tokenStack[len(tokenStack)-1] for both ']' and '}' delimiters.
   - Prevents potential panic on malformed or concurrent access.

3. syscall: Replace panic with error return in Accept4 functions
   - syscall_freebsd.go, syscall_netbsd.go, syscall_openbsd.go:
   - Change panic("RawSockaddrAny too small") to return EINVAL error.
   - Allows graceful error handling instead of crashing the program.

These fixes improve robustness in concurrent scenarios and abnormal
input handling, following Go's error handling best practices.

Fixes: Lock management issues in fork operations
Fixes: Potential array bounds violations in JSON parsing
Fixes: Inappropriate panic usage in syscall package

Change-Id: Ia1b2c3d4e5f6a7b8c9d0e1f2a3b4c5d6e7f8a9b0
@gopherbot
Copy link
Contributor

This PR (HEAD: 387ee25) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/749821.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/749821.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Keith Randall:

Patch Set 2:

(3 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/749821.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants