Skip to content

crypto/x509: improve error message when signature algorithm is unsupported#77943

Open
tobiasworkstech wants to merge 2 commits intogolang:masterfrom
tobiasworkstech:fix-x509-algorithm-error-message
Open

crypto/x509: improve error message when signature algorithm is unsupported#77943
tobiasworkstech wants to merge 2 commits intogolang:masterfrom
tobiasworkstech:fix-x509-algorithm-error-message

Conversation

@tobiasworkstech
Copy link

Fixes #7735

When certificate chain verification fails because the CA's signature
algorithm is not supported, the error was wrapped in an
UnknownAuthorityError producing a misleading message:

x509: certificate signed by unknown authority (possibly because of
"x509: cannot verify signature: algorithm unimplemented" while trying
to verify candidate authority certificate "CA Name")

The phrase "signed by unknown authority" is confusing: the authority
certificate is known and found, but its signature algorithm cannot
be verified by this build of Go. The inner error string is accurate
but buried and obscured by the outer phrasing.

This change detects when hintErr is ErrUnsupportedAlgorithm and
produces a clearer, direct message instead:

x509: certificate signed by unknown authority (the signature algorithm
of authority certificate "CA Name" is not supported)

The existing expectHashError test is updated to match.

…orted

When certificate chain verification fails because the CA's signature
algorithm is not supported, the error was wrapped in an
UnknownAuthorityError with the generic message:

  x509: certificate signed by unknown authority (possibly because of
  "x509: cannot verify signature: algorithm unimplemented" while trying
  to verify candidate authority certificate "CA Name")

The phrase "signed by unknown authority" is misleading: the authority is
known, but its signature algorithm cannot be verified. When hintErr is
ErrUnsupportedAlgorithm, produce a clearer message instead:

  x509: certificate signed by unknown authority (the signature algorithm
  of authority certificate "CA Name" is not supported)

Fixes golang#7735
@google-cla
Copy link

google-cla bot commented Mar 4, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tobiasworkstech
Copy link
Author

I have now signed the Google Individual CLA. Please re-check.

@gopherbot
Copy link
Contributor

This PR (HEAD: 0f15c7f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/751460.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/751460.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/751460.
After addressing review feedback, remember to publish your drafts!

@tobiasworkstech tobiasworkstech force-pushed the fix-x509-algorithm-error-message branch from 0f15c7f to e06decb Compare March 4, 2026 21:08
@gopherbot
Copy link
Contributor

This PR (HEAD: e06decb) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/751460.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crypto/x509: add more detail to the error message arising from a missing hash function.

2 participants