Skip to content

crypto/x509: avoid false wildcard matches for 2-label exclusions#77962

Open
willswire wants to merge 1 commit intogolang:release-branch.go1.25from
willswire:release-branch.go1.25
Open

crypto/x509: avoid false wildcard matches for 2-label exclusions#77962
willswire wants to merge 1 commit intogolang:release-branch.go1.25from
willswire:release-branch.go1.25

Conversation

@willswire
Copy link

When evaluating excluded DNS name constraints against wildcard SANs,
matchDomainConstraint trims one label from both names so that excluded
subdomains like foo.example.com correctly preclude *.example.com.

That trimming was also applied to two-label constraints. For a
constraint like blocked.example, trimming reduces it to example, which
can incorrectly match unrelated wildcard names.

Only apply the wildcard/excluded trimming path when the excluded
constraint has more than two labels.

This change adds regression coverage for the wildcard-matching behavior
in TestExcludedWildcardNameConstraints and adds a chain-level case in
TestConstraintCases.

Updates #76935
Updates #77323

@google-cla
Copy link

google-cla bot commented Mar 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@willswire willswire changed the base branch from release-branch.go1.25 to master March 5, 2026 15:09
@willswire willswire changed the base branch from master to release-branch.go1.25 March 5, 2026 15:10
@gopherbot
Copy link
Contributor

This PR (HEAD: 7d5958a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/751880.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/751880.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants