Skip to content

all: update to x/tools@55fb96f#78744

Closed
AkihiroSuda wants to merge 2 commits intogolang:masterfrom
AkihiroSuda:x-tools
Closed

all: update to x/tools@55fb96f#78744
AkihiroSuda wants to merge 2 commits intogolang:masterfrom
AkihiroSuda:x-tools

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Contributor

@AkihiroSuda AkihiroSuda commented Apr 14, 2026

This brings in CL 765402 etc.

For #73878

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

This PR (HEAD: 4835586) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/766880.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@AkihiroSuda
all: update to x/tools@55fb96f
fe3bb31 
This brings in CL 765402 etc.

For golang#73878
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

This PR (HEAD: fe3bb31) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/766880.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@AkihiroSuda
cmd/go: use unitchecker.Config.Module in vetConfig
a7bdfea 
unitchecker.Config was updated in CL 765402 to contain a full Module struct.
This commit updates vetConfig accordingly.

Follow-up to https://go-review.googlesource.com/c/tools/+/676455/comments/34707247_5e471a91

> The next step is to make the corresponding change to unitchecker, used by go vet/fix.
> You'll need to add fields to x/tools/go/analysis/unitchecker.Config first,
> then to cmd/go/internal/work.vetConfig to populate the data.

Updates golang#73878
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

This PR (HEAD: a7bdfea) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/766880.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

Message from Alan Donovan:

Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/766880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-04-14T14:54:17Z","revision":"d839ad1011a8cbcd581415efaaebfd5d7d27fca3"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/766880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

Message from Alan Donovan:

Patch Set 3: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_57259>)

Please don’t reply on this GitHub thread. Visit golang.org/cl/766880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

Message from Go LUCI:

Patch Set 3:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/766880.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/766880.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Apr 14, 2026
@AkihiroSuda @gopherbot
all: update to x/tools@55fb96f
5cd1683 
This brings in CL 765402 etc.

For #73878

Change-Id: I9ef50fc6bb9beb26e4e3389a49fbc699513884e3
GitHub-Last-Rev: a7bdfea
GitHub-Pull-Request: #78744
Reviewed-on: https://go-review.googlesource.com/c/go/+/766880
LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
Reviewed-by: David Chase <drchase@google.com>
@gopherbot
Copy link
Copy Markdown
Contributor

gopherbot commented Apr 14, 2026

This PR is being closed because golang.org/cl/766880 has been merged.

@gopherbot gopherbot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AkihiroSuda @gopherbot