fmt: clarify %q is for runes, not integers; note go vet warning#78806
Open
Jah-yee wants to merge 1 commit intogolang:masterfrom
Open
fmt: clarify %q is for runes, not integers; note go vet warning#78806Jah-yee wants to merge 1 commit intogolang:masterfrom
Jah-yee wants to merge 1 commit intogolang:masterfrom
Conversation
…usage Fixes golang#78486 The %q verb was listed under Integer but it is semantically for character (rune) types, not integers. As of Go 1.26, go vet correctly warns when %q is used with integer arguments (golang#72850). This change: 1. Removes %c and %q from the Integer section 2. Creates a new Rune section with %c and %q 3. Adds a note that go vet warns about %q with integers
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good day,
This PR addresses issue #78486, which notes that the fmt documentation incorrectly lists the %q verb under the Integer section, suggesting it is a valid format for int types. However, as of Go 1.26, go vet correctly warns when %q is used with integer arguments (see #72850).
Changes
Removed %c and %q from the Integer section - These verbs are semantically for character (rune) types, not arbitrary integers.
Created a new Rune section - Moved %c and %q into a dedicated Rune section, which correctly categorizes them.
Added a note - The new Rune section includes a note explaining that go vet (as of Go 1.26) warns when %q is used with integers, and suggests using %d, %x, or %o instead for integer formatting.
The %q verb for double-quoted strings (under String and slice of bytes) is unchanged.
Testing
This is a documentation-only change. The existing behavior of the fmt package is unaffected.
Warmly,
RoomWithOutRoof