Skip to content

net/http: reject userinfo in CrossOriginProtection#79766

Open
jub0bs wants to merge 1 commit into
golang:masterfrom
jub0bs:cop-check-userinfo
Open

net/http: reject userinfo in CrossOriginProtection#79766
jub0bs wants to merge 1 commit into
golang:masterfrom
jub0bs:cop-check-userinfo

Conversation

@jub0bs
Copy link
Copy Markdown
Contributor

@jub0bs jub0bs commented May 31, 2026

(*CrossOriginProtection).AddTrustedOrigin fails if its argument contains
a path, a query, and/or a fragment, but it doesn't check for the
presence of a userinfo part. Such an omission doesn't affect security
(because serialized origins don't contain any userinfo part), but it
causes invalid origins to be silently accepted, which could create some
confusion.

With this CL, the method now also fails if its argument contains a
userinfo part (even if it's empty).

(*CrossOriginProtection).AddTrustedOrigin fails if its argument contains
a path, a query, and/or a fragment, but it doesn't check for the
presence of a userinfo part. Such an omission doesn't affect security
(because serialized origins don't contain any userinfo part), but it
causes invalid origins to be silently accepted, which could create some
confusion.

With this CL, the method now also fails if its argument contains a
userinfo part (even if it's empty).
@gopherbot
Copy link
Copy Markdown
Contributor

This PR (HEAD: 232ab09) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/785520.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from jub0bs:

Patch Set 1:

(2 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Viacheslav Danilin:

Patch Set 1: Code-Review+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Filippo Valsorda:

Patch Set 1: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Filippo Valsorda:

Patch Set 1: Auto-Submit+1 Commit-Queue+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2026-06-04T19:08:59Z","revision":"af20728e1926ae6e2355d00e9463f42f345fb563"}


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from Filippo Valsorda:

Patch Set 1: -Commit-Queue

(Performed by <GERRIT_ACCOUNT_60063> on behalf of <GERRIT_ACCOUNT_11715>)


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1:

This CL has passed the run


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Copy Markdown
Contributor

Message from golang-scoped@luci-project-accounts.iam.gserviceaccount.com:

Patch Set 1: LUCI-TryBot-Result+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/785520.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants