Skip to content

net/http/httputil: do not forward h2c upgrade requests#80425

Open
kingljl wants to merge 4 commits into
golang:masterfrom
kingljl:fix-the-issue-of-blocking-http2
Open

net/http/httputil: do not forward h2c upgrade requests#80425
kingljl wants to merge 4 commits into
golang:masterfrom
kingljl:fix-the-issue-of-blocking-http2

Conversation

@kingljl

@kingljl kingljl commented Jul 16, 2026

Copy link
Copy Markdown

ReverseProxy no longer forwards h2c upgrade requests to the backend.
Other protocol upgrades, such as WebSocket, continue to be forwarded.

An h2c upgrade multiplexes requests over a single connection,
bypassing the controls enforced by Director or Rewrite.

Fixes #80416.

kingljl added 3 commits July 16, 2026 11:57
Add comments explaining the handling of 'h2c' upgrades in reverse proxy.
Fix formatting issue by adding a newline at the end of the file.
This test ensures that an 'Upgrade: h2c' header in a client request is not forwarded to the backend, verifying that the backend does not receive the Upgrade and Connection headers.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 988b4ba) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/801380.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/801380.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Ian Lance Taylor:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/801380.
After addressing review feedback, remember to publish your drafts!

@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: dab31f3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/801380.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

net/http/httputil: ReverseProxy forwards Upgrade headers and silently proxies HTTP/2

2 participants