cmd/go: reject cgo -sectcreate linker flags by default#80491
Open
carrerasdarren-cell wants to merge 1 commit into
Open
cmd/go: reject cgo -sectcreate linker flags by default#80491carrerasdarren-cell wants to merge 1 commit into
carrerasdarren-cell wants to merge 1 commit into
Conversation
Contributor
|
This PR (HEAD: bfc86b7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/803620. Important tips:
|
Contributor
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/803620. |
Contributor
|
Message from Ian Lance Taylor: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/803620. |
The Darwin linker reads the file named by -sectcreate and embeds its contents in the output. Allowing dependency-supplied #cgo LDFLAGS to use it lets a module read arbitrary files available to the build. Reject file-backed uses by default. Preserve the established __RESTRICT,__restrict,/dev/null form used for Darwin hardening, since it cannot expose file contents. Users who explicitly trust another use can retain the existing CGO_LDFLAGS_ALLOW override. Fixes golang#78750.
carrerasdarren-cell
force-pushed
the
fix-cgo-darwin-sectcreate-78750
branch
from
July 21, 2026 23:31
bfc86b7 to
26dcf14
Compare
Contributor
|
This PR (HEAD: 26dcf14) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/803620. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Darwin linker -sectcreate option reads a file and embeds its contents.
The existing cgo linker allowlist accepts this option, so a dependency can
make go build read an arbitrary file available to the build process.
Reject file-backed -Wl,-sectcreate,... flags in package-provided #cgo
LDFLAGS by default. Preserve the established
-Wl,-sectcreate,__RESTRICT,__restrict,/dev/null hardening form because it
does not expose useful file contents. Trusted uses can explicitly opt in
with CGO_LDFLAGS_ALLOW, as with other rejected flags.
Add a script test for default rejection, explicit opt-in, and the preserved
hardening form.
Fixes #78750.