Skip to content

html/template: handle CDATA in foreign script elements#80492

Open
carrerasdarren-cell wants to merge 1 commit into
golang:masterfrom
carrerasdarren-cell:fix-html-template-cdata-62617
Open

html/template: handle CDATA in foreign script elements#80492
carrerasdarren-cell wants to merge 1 commit into
golang:masterfrom
carrerasdarren-cell:fix-html-template-cdata-62617

Conversation

@carrerasdarren-cell

@carrerasdarren-cell carrerasdarren-cell commented Jul 21, 2026

Copy link
Copy Markdown

HTML tokenizers recognize CDATA sections when the current node is SVG or
MathML. An apparent closing script tag inside such a section is text, but
html/template currently ends its script context there. A later action is
therefore HTML-escaped instead of JavaScript-escaped. In a template literal,
attacker-controlled interpolation can execute.

This change tracks the foreign namespace transitions that affect CDATA,
including HTML integration points and breakout tags, and preserves the
JavaScript context until the CDATA section ends. Dynamically ambiguous
attributes retain the stricter JavaScript-escaping direction.

The issue reproducer was confirmed on current master. With an inert local
payload that assigned 1337 to a sentinel, headless Chrome changed the sentinel
from 0 to 1337. The patched rendering escaped the interpolation syntax and the
sentinel remained 0.

Validation included the complete short standard-library suite, ten
race-enabled html/template runs, 100 ordinary html/template runs, and go vet.

Fixes #62617.

HTML tokenizers treat CDATA sections in SVG and MathML as text. html/template currently recognizes an apparent </script> within such a section as the end of a script element and applies HTML instead of JavaScript escaping to later actions. In a template literal, this can allow attacker-controlled interpolation and XSS.

Track foreign-content namespaces and HTML integration points, and preserve JavaScript context through CDATA sections in foreign script elements.

Fixes golang#62617.
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: ab384bd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/803621.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot

Copy link
Copy Markdown
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/803621.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html/template: treatment of CDATA sections in foreign content diverges from browsers

2 participants