cmd/compile: export inline method bodies for exported type aliases by Capstan · Pull Request #82477 · golang/go

Capstan · 2026-10-23T23:59:22Z

When package b declares an exported type alias "type T = a.T" for a
non-interface type a.T defined in an imported package a, the unified
IR linker does not export a.T's inline method bodies in b's export
data. relocObj only walks a type's methods when the object is not an
alias, and exportBody only re-exports an imported body if b itself
inlined a call to it (fn.Inl.HaveDcl). As a result, a package c that
imports b, but not a, cannot inline methods called through b.T.

Fix this by indexing imported static method bodies by their receiver
type symbol in readPackage (importTypeBodies). When relocObj relocates
a top-level, local, exported type alias to an imported non-interface
type, forward the aliased type's inline method bodies into b's export
data. While relocating a forwarded body, also forward the inline
bodies of imported functions and receiver types it references,
including entries that were already relocated. Packages without such
aliases export the same data as before.

Alias chains also work: if c instead declares "type T = b.T", c.T
resolves to a.T, so c forwards the bodies it read from b's export data
and a package d that imports only c can inline them.
TestInlineTypeAliasMethods covers this two-hop case.

Fixes #82474

When package b declares an exported type alias "type T = a.T" for a non-interface type a.T defined in an imported package a, the unified IR linker does not export a.T's inline method bodies in b's export data. relocObj only walks a type's methods when the object is not an alias, and exportBody only re-exports an imported body if b itself inlined a call to it (fn.Inl.HaveDcl). As a result, a package c that imports b, but not a, cannot inline methods called through b.T. Fix this by indexing imported static method bodies by their receiver type symbol in readPackage (importTypeBodies). When relocObj relocates a top-level, local, exported type alias to an imported non-interface type, forward the aliased type's inline method bodies into b's export data. While relocating a forwarded body, also forward the inline bodies of imported functions and receiver types it references, including entries that were already relocated. Packages without such aliases export the same data as before. Alias chains also work: if c instead declares "type T = b.T", c.T resolves to a.T, so c forwards the bodies it read from b's export data and a package d that imports only c can inline them. TestInlineTypeAliasMethods covers this two-hop case.

gopherbot · 2026-10-24T00:13:18Z

This PR (HEAD: 83ce276) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/853585.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2026-10-24T00:31:18Z

Message from Gopher Robot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.