-
Notifications
You must be signed in to change notification settings - Fork 488
Ignore vendor directory while linting './...' #377
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
This PR (HEAD: 22e3b9e) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/lint/+/96092 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/96092. |
Message from Giovanni Bajo: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/96092. |
Message from Joe Richey: Patch Set 1: It seems like this should be closed in favor of CL 96085 That CL seems to properly handle the edge cases described here: Please don’t reply on this GitHub thread. Visit golang.org/cl/96092. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
This PR (HEAD: 6907c1d) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/lint/+/96092 to see it. Tip: You can toggle comments from me using the |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
This PR (HEAD: ce60723) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/#/c/lint/+/96092 to see it. Tip: You can toggle comments from me using the |
Message from Gerrit Bot: Uploaded patch set 3: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/96092. |
Is there any changes required to merge this PR? |
Duplicate of #325 |
Ignore vendor directory, closes #320