cmd/gomobile: support macOS and Catalyst #65

ydnar · 2021-04-13T17:45:59Z

Add support for macOS (non-Catalyst) and Catalyst targets.

The compiled library is packaged into a "fat" XCFramework file (as
opposed to a Framework), which includes binaries for iOS, macOS,
MacCatalyst (iOS on macOS), and iOS Simulator targets, for amd64 and
arm64 architectures.

The generated XCFramework file is suitable for distribution as a binary
Swift Package Manager package:
https://developer.apple.com/documentation/swift_packages/distributing_binary_frameworks_as_swift_packages

This change is based on earlier work:
#45
#63

Fixes golang/go#36856

google-cla · 2021-04-13T17:46:21Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

ydnar · 2021-04-13T17:47:18Z

@googlebot I consent.

google-cla · 2021-04-13T17:47:25Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

dpwiese · 2021-04-16T16:39:26Z

@googlebot I consent.

google-cla · 2021-04-16T16:39:33Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

waylybaye · 2021-04-17T01:49:19Z

@googlebot I consent.

gopherbot · 2021-04-17T01:52:27Z

This PR (HEAD: fb6ffaf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/310949 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-04-17T01:54:17Z

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://golang.org/doc/contribute.html#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

nadimkobeissi · 2021-05-18T18:45:16Z

This is a pretty exciting and important PR, any idea when it will get merged? Thank you for your contributions.

imWildCat · 2021-05-19T00:43:34Z

cc @hyangah

nadimkobeissi · 2021-05-30T08:51:02Z

Bump :-)

deepumukundan · 2021-07-06T20:37:27Z

Thanks for the contributions. Seems like gopherbot has not assigned any reviewers here and no activity is seen at https://go-review.googlesource.com/c/mobile/+/310949. I know gomobile is experimental and all, but still this is a pretty important change (With Catalyst and SPM being around for 2+ years for public) and no way for us to bump up the priority for someone from google to take a look at. 😿 . Will pinging @gopherbot in the thread help? Just trying out here.

nadimkobeissi · 2021-07-08T15:00:10Z

cc. @hajimehoshi maybe?

ydnar · 2021-07-08T15:09:56Z

cc. @hajimehoshi maybe?

Happy to work with whomever wants to review this. I’d love to see this merged. 👍

gopherbot · 2021-07-08T16:52:58Z

Message from Hajime Hoshi:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-08T16:55:24Z

Message from Hajime Hoshi:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

create one framework for all targets: ios, simulator and catalyst, every framework contains at least one arch library, and combine all framework into one xcframework

Adds macosx on amd64 and arm64 targets to the fat xcframework. This enables the generated xcframework to be used as a binary dependency in Swift Package Manager: https://developer.apple.com/documentation/swift_packages/distributing_binary_frameworks_as_swift_packages and used or tested using the SwiftPM command-line tools on macOS, e.g. 'swift test'

gopherbot · 2021-07-08T17:02:58Z

This PR (HEAD: b678ba0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/310949 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-09T16:44:05Z

Message from Hajime Hoshi:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T16:51:37Z

This PR (HEAD: 221210c) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/310949 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-09T16:56:23Z

Message from Hajime Hoshi:

Patch Set 17: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T16:58:47Z

Message from Go Bot:

Patch Set 17:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T16:58:48Z

Message from Randy Reddig:

Patch Set 16:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T17:03:36Z

Message from Go Bot:

Patch Set 17: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T17:08:28Z

Message from Hajime Hoshi:

Patch Set 17: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T19:49:03Z

Message from Hyang-Ah Hana Kim:

Patch Set 17:

(6 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

...instead of string concatenation. CL feedback.

Just use append.

gopherbot · 2021-07-09T21:46:54Z

This PR (HEAD: 623f8f3) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/310949 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

gopherbot · 2021-07-09T21:54:28Z

Message from Randy Reddig:

Patch Set 17:

(7 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T22:01:56Z

Message from Hyang-Ah Hana Kim:

Patch Set 18: Run-TryBot+1 Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T22:04:18Z

Message from Go Bot:

Patch Set 18:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T22:11:26Z

Message from Go Bot:

Patch Set 18: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2021-07-09T22:15:53Z

Message from Randy Reddig:

Patch Set 18:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/310949.
After addressing review feedback, remember to publish your drafts!

Add support for macOS (non-Catalyst) and Catalyst targets. The compiled library is packaged into a "fat" XCFramework file (as opposed to a Framework), which includes binaries for iOS, macOS, MacCatalyst (iOS on macOS), and iOS Simulator targets, for amd64 and arm64 architectures. The generated XCFramework file is suitable for distribution as a binary Swift Package Manager package: https://developer.apple.com/documentation/swift_packages/distributing_binary_frameworks_as_swift_packages This change is based on earlier work: #45 #63 Fixes golang/go#36856 Change-Id: Iabe535183c7215c68838d6c8f31618d8bceefdcf GitHub-Last-Rev: 623f8f3 GitHub-Pull-Request: #65 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/310949 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Reviewed-by: Hajime Hoshi <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Trust: Hajime Hoshi <[email protected]> Run-TryBot: Hyang-Ah Hana Kim <[email protected]> TryBot-Result: Go Bot <[email protected]>

gopherbot · 2021-07-10T06:52:08Z

This PR is being closed because golang.org/cl/310949 has been merged.

nadimkobeissi · 2021-07-13T09:19:05Z

Thank you so much!

This is is a follow-up from my previous PR (#65). It makes gomobile aware of GOOS=ios and adds support for specifying specific Apple platforms, instead of overloading the "ios" platform. Supported platforms: ios, iossimulator, macos, and maccatalyst These can now be specified the -target argument to gomobile, e.g.: gomobile build -target=ios,iossimulator,macos,maccatalyst It preserves the current behavior of -target=ios, which will build for ios and iossimulator on supported architectures (arm64 and amd64). It adds platform-specific build tags so Go code can discriminate between different Apple platforms like maccatalyst (UIKit on macOS). This PR also fixes a number of broken tests. TODO: cgo has a bug where c-archive builds targeting Catalyst will fail unless -tags=ios is supplied. See https://golang.org/issues/47228 Fixes https://golang.org/issues/47212 Updates https://golang.org/issues/47228 Change-Id: Ib1a2f5302c5edd0704c13ffbe8f4061211f50d4e GitHub-Last-Rev: 01ab28e GitHub-Pull-Request: #70 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/334689 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> Trust: Hyang-Ah Hana Kim <[email protected]> Trust: Hajime Hoshi <[email protected]>

google-cla bot added the cla: no label Apr 13, 2021

dpwiese mentioned this pull request Apr 16, 2021

Support building for target catalyst #45

Closed

google-cla bot added cla: yes and removed cla: no labels Apr 17, 2021

ydnar mentioned this pull request May 18, 2021

cmd/gomobile: support Catalyst and Apple Silicon #63

Closed

ydnar changed the title ~~Catalyst + macOS support~~ mobile: support macOS and Catalyst May 24, 2021

dpwiese and others added 6 commits July 8, 2021 10:00

nominally working example for catalyst

3235347

remove mistaken hardcoded framework filenames

e581a49

update test and minor go fmt fix

cb8e364

Support Apple Silicon and Catalyst

eb6b77b

create one framework for all targets: ios, simulator and catalyst, every framework contains at least one arch library, and combine all framework into one xcframework

remove catalyst in allArchs

259d861

ydnar force-pushed the support-catalyst branch from fb6ffaf to b678ba0 Compare July 8, 2021 17:02

cmd/gomobile: remove ARCH=arm64 from test

221210c

ydnar added 6 commits July 9, 2021 14:02

cmd/gomobile: remove comment per CL feedback

45defed

cmd/gomobile: add space after // (CL feedback)

cb1feed

cmd/gomobile: reorganize variables; use filepath.Join

6fd5aa7

...instead of string concatenation. CL feedback.

cmd/gomobile: remove a few single-use variables

964653a

cmd/gomobile: remove slice assignment optimization

b39ae24

Just use append.

go.sum: go mod tidy; CL feedback

623f8f3

gopherbot closed this Jul 10, 2021

ydnar mentioned this pull request Jul 14, 2021

cmd/gomobile: improve support for macOS and Catalyst #70

Closed

NorrinRadd mentioned this pull request Jul 15, 2021

Go Mobile builds xcframeworks now breez/breez#137

Closed

ydnar mentioned this pull request Jul 15, 2021

x/mobile: gomobile bind is ignoring target architecture parameter golang/go#47212

Closed

NorrinRadd mentioned this pull request Jul 15, 2021

iOS build fails with "No such module bindings" breez/breezmobile#522

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/gomobile: support macOS and Catalyst #65

cmd/gomobile: support macOS and Catalyst #65

ydnar commented Apr 13, 2021 •

edited

Loading

google-cla bot commented Apr 13, 2021

ydnar commented Apr 13, 2021

google-cla bot commented Apr 13, 2021

dpwiese commented Apr 16, 2021

google-cla bot commented Apr 16, 2021

waylybaye commented Apr 17, 2021

gopherbot commented Apr 17, 2021

gopherbot commented Apr 17, 2021

nadimkobeissi commented May 18, 2021

imWildCat commented May 19, 2021

nadimkobeissi commented May 30, 2021

deepumukundan commented Jul 6, 2021

nadimkobeissi commented Jul 8, 2021

ydnar commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 10, 2021

nadimkobeissi commented Jul 13, 2021

cmd/gomobile: support macOS and Catalyst #65

cmd/gomobile: support macOS and Catalyst #65

Conversation

ydnar commented Apr 13, 2021 • edited Loading

google-cla bot commented Apr 13, 2021

ydnar commented Apr 13, 2021

google-cla bot commented Apr 13, 2021

dpwiese commented Apr 16, 2021

google-cla bot commented Apr 16, 2021

waylybaye commented Apr 17, 2021

gopherbot commented Apr 17, 2021

gopherbot commented Apr 17, 2021

nadimkobeissi commented May 18, 2021

imWildCat commented May 19, 2021

nadimkobeissi commented May 30, 2021

deepumukundan commented Jul 6, 2021

nadimkobeissi commented Jul 8, 2021

ydnar commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 8, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 9, 2021

gopherbot commented Jul 10, 2021

nadimkobeissi commented Jul 13, 2021

ydnar commented Apr 13, 2021 •

edited

Loading