Skip to content

example: updates for XCFramework and Mac Catalyst #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

example: updates for XCFramework and Mac Catalyst #72

wants to merge 2 commits into from

Conversation

ydnar
Copy link
Contributor

@ydnar ydnar commented Sep 16, 2021

This updates examples for the changes in golang.org/cl/334689 for
.xcframework files and Mac Catalyst.

Depends on golang.org/cl/334689

https://go-review.googlesource.com/c/mobile/+/334689/28/example/bind/ios/README#1

@google-cla google-cla bot added the cla: yes label Sep 16, 2021
ydnar added a commit to ydnar/gomobile that referenced this pull request Sep 16, 2021
@ydnar
.gitignore, example/{bind,ivy}: revert to master
01ab28e 
CL feedback:
https://go-review.googlesource.com/c/mobile/+/334689/28/example/bind/ios/README#1

New CL: golang#72
@gopherbot
Copy link
Contributor

This PR (HEAD: 8498622) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/350489 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2: Patch Set 1 was rebased

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 64da8e6) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/mobile/+/350489 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Randy Reddig:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Changkun Ou:

Patch Set 3: Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hyang-Ah Hana Kim:

Patch Set 3: Code-Review+2 Trust+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Hajime Hoshi:

Patch Set 3: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go Bot:

Patch Set 3: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/350489.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 22, 2021
@ydnar @hajimehoshi
example: updates for XCFramework and Mac Catalyst
b5eb1ab 
This updates examples for the changes in golang.org/cl/334689 for
.xcframework files and Mac Catalyst.

Depends on golang.org/cl/334689

https://go-review.googlesource.com/c/mobile/+/334689/28/example/bind/ios/README#1

Change-Id: Ice89e7e675c8f190c7040407908f619a7631fd2b
GitHub-Last-Rev: 64da8e6
GitHub-Pull-Request: #72
Reviewed-on: https://go-review.googlesource.com/c/mobile/+/350489
Reviewed-by: Changkun Ou <[email protected]>
Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Hajime Hoshi <[email protected]>
Trust: Hyang-Ah Hana Kim <[email protected]>
Run-TryBot: Hajime Hoshi <[email protected]>
TryBot-Result: Go Bot <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/350489 has been merged.

@gopherbot gopherbot closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ydnar @gopherbot