Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

Support dynamic return values #67

Closed
wants to merge 1 commit into from
Closed

Conversation

dmvk
Copy link

@dmvk dmvk commented Mar 15, 2017

Hi,

thanks for an amazing job you guys are doing! It would be really useful if Call return values could be changed dynamically as referred here:

#34 (comment)

Thanks,
D.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@dmvk
Copy link
Author

dmvk commented Mar 15, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@sivakku
Copy link

sivakku commented Oct 4, 2017

Any reason why this fix is not yet merged in? other wise calling Return inside Do() seems broken

@balshetzer
Copy link
Collaborator

Thanks for this PR. Another solution to this problem has been pulled with #126.

@balshetzer balshetzer closed this Nov 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants