Skip to content

dns/dnsmessage: reject names with dots inside label #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

dns/dnsmessage: reject names with dots inside label #154

wants to merge 1 commit into from

Conversation

mateusz834
Copy link
Member

@gopherbot
Copy link
Contributor

This PR (HEAD: b258830) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/443215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: c433dd4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/443215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: d6d389e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/443215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 42d0d8e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/443215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: c61ec10) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/443215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: 8a8703a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/net/+/443215 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Mateusz Poliwczak:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/443215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/443215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 6: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/443215.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Roland Shoemaker:

Patch Set 6: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/443215.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request May 24, 2023
@mateusz834 @gopherbot
dns/dnsmessage: reject names with dots inside label
ca96da6 
Fixes golang/go#56246

Change-Id: I9c8d611d1305536a7510bf6c4a02a5e551aa657a
GitHub-Last-Rev: 8a8703a
GitHub-Pull-Request: #154
Reviewed-on: https://go-review.googlesource.com/c/net/+/443215
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Roland Shoemaker <[email protected]>
Reviewed-by: Matthew Dempsky <[email protected]>
Run-TryBot: Mateusz Poliwczak <[email protected]>
Auto-Submit: Roland Shoemaker <[email protected]>
@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/443215 has been merged.

@gopherbot gopherbot closed this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/net/dnsmessage: dots inside dns name label should be considered invalid
2 participants
@mateusz834 @gopherbot