-
Notifications
You must be signed in to change notification settings - Fork 1.2k
http2: add configuration options when constructing http2 transport #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: a242348) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/236498 to see it. Tip: You can toggle comments from me using the |
Message from Chao Xu: Patch Set 1: This directly solves https://go-review.googlesource.com/c/net/+/198040/18#message-d1a7ce662534f798bb6b6702d6af575bebf41e45. I'm happy to open an issue in golang/go if that's preferred. Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Russ Cox: Patch Set 1: We're closing in on the Go 1.15 beta. Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Chao Xu: Patch Set 1:
In order to put the health check I added in https://go-review.googlesource.com/c/net/+/198040 in use. The feature by default is off. Without this change, it's very difficult to change the ReadIdleTimeout and PingTimeout. One would need to use the unsafe package like what I did in the test. Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
a242348
to
d7da2b4
Compare
This PR (HEAD: d7da2b4) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/236498 to see it. Tip: You can toggle comments from me using the |
Message from Chao Xu: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Michael Fraenkel: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Chao Xu: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Chao Xu: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Michael Fraenkel: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
d7da2b4
to
6619d1f
Compare
This PR (HEAD: 6619d1f) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/236498 to see it. Tip: You can toggle comments from me using the |
This allows the caller to change some configurations of the http2 transport when constructing it from an http1 transport.
6619d1f
to
1d2c348
Compare
This PR (HEAD: 1d2c348) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/net/+/236498 to see it. Tip: You can toggle comments from me using the |
Message from Chao Xu: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Bryan C. Mills: Patch Set 6: Commit message was updated. Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Bryan C. Mills: Patch Set 6: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Brad Fitzpatrick: Patch Set 6: Code-Review-2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Chao Xu: Patch Set 6: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Bryan C. Mills: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Chao Xu: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Message from Chao Xu: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/236498. |
Superseded by https://go-review.googlesource.com/c/net/+/264017/. |
This allows the caller to change some configurations of the http2 transport when constructing it from an http1 transport.
Fixes golang/go#40201.