oauth2: fix docs for Config.DeviceAuth#763
Conversation
Config.DeviceAccess should be Config.DeviceAuth.
|
This PR (HEAD: 4728e08) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/636216. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Patrik Lundin: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
Config.DeviceAccess should be Config.DeviceAuth. merges golang#763 (golang#763)
|
Message from Funda Secgin: Patch Set 2: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Jorropo: Patch Set 2: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-13T01:10:50Z","revision":"a5c8f44f2a17b40fe5a61d4762a320f6adcecb53"} Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Jorropo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
Config.DeviceAccess should be Config.DeviceAuth
|
This PR (HEAD: 2d6b4fd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/636216. Important tips:
|
|
Message from Gopher Robot: Patch Set 3: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Patrik Lundin: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Jorropo: Patch Set 3: Auto-Submit+1 Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-02-13T07:57:34Z","revision":"f9e96db6353035fc618a2ded1ecc4d263a30e2da"} Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Jorropo: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
|
Message from Dmitri Shuralyov: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/636216. |
Config.DeviceAccess should be Config.DeviceAuth when using GenerateVerifier() or S256ChallengeOption() Change-Id: Ie21a808387f731d270ae54ea1705de3e786cad7f GitHub-Last-Rev: 2d6b4fd GitHub-Pull-Request: #763 Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/636216 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: Jorropo <jorropo.pgm@gmail.com>
|
This PR is being closed because golang.org/cl/636216 has been merged. |
Config.DeviceAccess should be Config.DeviceAuth when using GenerateVerifier() or S256ChallengeOption()