Skip to content

cmd/benchstat: add example benchmarking workflow to package comment #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

cmd/benchstat: add example benchmarking workflow to package comment #1

wants to merge 1 commit into from

Conversation

nsajko
Copy link

@nsajko nsajko commented Jul 31, 2019

README.md in cmd/benchstat was removed to prevent duplication and bit rot, because it was the duplicate of the package comment.

Fixes golang/go#23471

@gopherbot
Copy link
Contributor

This PR (HEAD: 339e355) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/perf/+/188438 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: d9efb36) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/perf/+/188438 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

This PR (HEAD: b8c3c35) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/perf/+/188438 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Neven Sajko:

Patch Set 5:

Adding you as a reviewer because you said that would be OK in #23471


Please don’t reply on this GitHub thread. Visit golang.org/cl/188438.
After addressing review feedback, remember to publish your drafts!

@nsajko nsajko closed this by deleting the head repository Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

x/perf/cmd/benchstat: tips or quickstart for newcomers
3 participants