internal/lsp: fix swallowed package errors #102
Conversation
|
This PR (HEAD: 68abd43) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/177605 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Ian Cottrell: Patch Set 1: Run-TryBot+1 Code-Review+1 (2 comments) Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=ae4f75f4 Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Gobot Gobot: Patch Set 1: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
evandigby
force-pushed
the
fix-diagnostics
branch
from
68abd43 to
01b0de1
Compare
|
This PR (HEAD: 01b0de1) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/177605 to see it. Tip: You can toggle comments from me using the |
|
Message from Evan Digby: Patch Set 2: (2 comments) Updated based on the comments. Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Evan Digby: Patch Set 2: (1 comment) Additional commentary on one of the fixes. Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Ian Cottrell: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
If a package has an error that makes it completely unparsable, such as containing a .go file with no "package" statement, the error was previously unreported. Such errors would manifest as other errors. Fixes golang/go#31712
evandigby
force-pushed
the
fix-diagnostics
branch
from
01b0de1 to
1581cbe
Compare
|
This PR (HEAD: 1581cbe) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/tools/+/177605 to see it. Tip: You can toggle comments from me using the |
|
Message from Evan Digby: Patch Set 3: (1 comment)
Updated to master and moved the test over. Thanks! Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Ian Cottrell: Patch Set 3: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Gobot Gobot: Patch Set 3: TryBots beginning. Status page: https://farmer.golang.org/try?commit=92002141 Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
|
Message from Gobot Gobot: Patch Set 3: TryBot-Result+1 TryBots are happy. Please don’t reply on this GitHub thread. Visit golang.org/cl/177605. |
If a package has an error that makes it completely unparseable, such as containing a .go file with no "package" statement, the error was previously unreported. Such errors would manifest as other errors. Fixes golang/go#31712 Change-Id: I11b8d0e2e4d64b03fbcb4c35e7f0b02fccc83fad GitHub-Last-Rev: 1581cbe GitHub-Pull-Request: #102 Reviewed-on: https://go-review.googlesource.com/c/tools/+/177605 Run-TryBot: Ian Cottrell <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Cottrell <[email protected]>
|
This PR is being closed because golang.org/cl/177605 has been merged. |
3 participants
If a package has an error that makes it completely unparseable, such as containing a .go file with no "package" statement, the error was previously unreported. Such errors would manifest as other errors.
Fixes golang/go#31712