gopls/internal: add code action "extract declarations to new file" #479

golopot · 2024-02-22T01:25:11Z

This code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed.

Fixes golang/go#65707

gopherbot · 2024-02-22T01:34:11Z

This PR (HEAD: 8c85d43) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T01:40:24Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T01:46:29Z

Message from [email protected]:

Patch Set 1:

(5 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T01:46:36Z

This PR (HEAD: 46ec4ff) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-22T01:58:43Z

Message from [email protected]:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T19:29:03Z

Message from Chiawen Chen:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T19:29:03Z

Message from Chiawen Chen:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T19:48:43Z

Message from Chiawen Chen:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T19:55:38Z

Message from Chiawen Chen:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-22T22:26:06Z

Message from Alan Donovan:

Patch Set 2:

(13 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-23T19:26:15Z

This PR (HEAD: da8e51f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-23T19:38:46Z

Message from Chiawen Chen:

Patch Set 2:

(16 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-27T21:46:44Z

Message from Alan Donovan:

Patch Set 4:

(39 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-02-28T18:40:57Z

This PR (HEAD: fa8abe3) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-02-28T18:47:25Z

Message from Chiawen Chen:

Patch Set 4:

(34 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-13T01:24:40Z

This PR (HEAD: 549739f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-13T01:30:53Z

Message from Chiawen Chen:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-14T20:53:11Z

Message from Alan Donovan:

Patch Set 6:

(37 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-24T15:27:26Z

Message from Alan Donovan:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-29T14:20:17Z

This PR (HEAD: 1a5533f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-05-29T14:47:41Z

Message from Chiawen Chen:

Patch Set 7:

(29 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-29T19:38:54Z

Message from Alan Donovan:

Patch Set 7:

(23 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-05-31T05:36:56Z

This PR (HEAD: aacfc85) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-18T15:31:50Z

Message from Go LUCI:

Patch Set 9:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-go1.19-linux-amd64 has failed with summary (view all results):

go on release-branch.go1.19 (commit 619b8fd)
tools on master (change 565895)

Build or test failure, click here for results.

Additional links for debugging:

Output for test golang.org/x/tools/gopls module

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T15:31:51Z

Message from Go LUCI:

Patch Set 9: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T16:32:59Z

Message from Alan Donovan:

Patch Set 9:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:13:04Z

This PR (HEAD: 418b472) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-18T23:25:36Z

Message from Chiawen Chen:

Patch Set 10:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:31:59Z

Message from Alan Donovan:

Patch Set 10: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:32:00Z

Message from Go LUCI:

Patch Set 10:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-18T23:15:54Z","revision":"86f23ab3b10b66d19c07042030a3a6633fd686c5"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:32:00Z

Message from Alan Donovan:

Patch Set 10: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:32:01Z

Message from Go LUCI:

Patch Set 10:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-go1.19-linux-amd64 has failed with summary (view all results):

go on release-branch.go1.19 (commit 619b8fd)
tools on master (change 565895)

Build or test failure, click here for results.

Additional links for debugging:

Output for test golang.org/x/tools/gopls module

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:32:01Z

Message from Go LUCI:

Patch Set 10: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-18T23:32:02Z

Message from Alan Donovan:

Patch Set 10:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-25T14:55:45Z

Message from Alan Donovan:

Patch Set 10:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

This code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed. Fixes golang/go#65707

…6.0 to v.17.0

gopherbot · 2024-06-26T01:25:07Z

This PR (HEAD: e551a8a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/565895.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-06-26T01:54:42Z

Message from Chiawen Chen:

Patch Set 11:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-26T13:38:50Z

Message from Alan Donovan:

Patch Set 11: Auto-Submit+1 Code-Review+2 Commit-Queue+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-26T13:45:31Z

Message from Go LUCI:

Patch Set 11:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-06-26T13:31:28Z","revision":"326c7ef4bb13d94f939676133698a1c221fcf9c4"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-26T13:58:27Z

Message from Alan Donovan:

Patch Set 11: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-26T13:58:28Z

Message from Go LUCI:

Patch Set 11:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-26T13:58:28Z

Message from Go LUCI:

Patch Set 11: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

This code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed. Fixes golang/go#65707 Change-Id: I3fd45afd3569e4e0cee17798a48bde6916eb57b8 GitHub-Last-Rev: e551a8a GitHub-Pull-Request: #479 Reviewed-on: https://go-review.googlesource.com/c/tools/+/565895 Auto-Submit: Alan Donovan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Findley <[email protected]> Reviewed-by: Alan Donovan <[email protected]>

gopherbot · 2024-06-26T14:12:05Z

Message from Robert Findley:

Patch Set 11: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/565895.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-06-26T14:18:41Z

This PR is being closed because golang.org/cl/565895 has been merged.

golopot force-pushed the movetonewfile branch 2 times, most recently from d03849b to 8c85d43 Compare February 22, 2024 01:27

golopot force-pushed the movetonewfile branch from 8c85d43 to 46ec4ff Compare February 22, 2024 01:41

golopot force-pushed the movetonewfile branch from 46ec4ff to da8e51f Compare February 23, 2024 19:25

golopot changed the title ~~gopls/internal: add code action "move to a new file"~~ gopls/internal: add code action "extract declarations to new file" Feb 23, 2024

golopot force-pushed the movetonewfile branch from da8e51f to fa8abe3 Compare February 28, 2024 18:39

golopot force-pushed the movetonewfile branch from 549739f to 1a5533f Compare May 29, 2024 14:14

golopot added 6 commits June 26, 2024 09:10

change tests to marker tests and other changes

b0fa8cd

refactors

7599dac

add tests

4ef584d

token.File.Offset -> safetoken.Offset and run go generate

499169d

pgf.File.FileStart -> pgf.Tok.Pos(0) and move release notes from v0.1…

e551a8a

…6.0 to v.17.0

golopot force-pushed the movetonewfile branch from 418b472 to e551a8a Compare June 26, 2024 01:20

gopherbot closed this Jun 26, 2024

gopls/internal: add code action "extract declarations to new file" #479

gopls/internal: add code action "extract declarations to new file" #479

Conversation

golopot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 22, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 23, 2024

gopherbot commented Feb 27, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Feb 28, 2024

gopherbot commented Mar 13, 2024

gopherbot commented Mar 13, 2024

gopherbot commented May 14, 2024

gopherbot commented May 24, 2024

gopherbot commented May 29, 2024

gopherbot commented May 29, 2024

gopherbot commented May 29, 2024

gopherbot commented May 31, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 18, 2024

gopherbot commented Jun 25, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024

gopherbot commented Jun 26, 2024