-
Notifications
You must be signed in to change notification settings - Fork 2.3k
gopls: report semantic tokens of top-level type constructor modifiers #511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 648bb1e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
This PR (HEAD: afd37c8) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
This PR (HEAD: 174ba9f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
This PR (HEAD: f457334) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
This PR (HEAD: 0ef01b9) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
9d811e9
to
b37e520
Compare
This PR (HEAD: b37e520) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
This PR (HEAD: 33b1585) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
0e1e842
to
01c46c0
Compare
This PR (HEAD: 01c46c0) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from Alan Donovan: Patch Set 9: (11 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
This PR (HEAD: 5e28ecb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from xxx Lulu: Patch Set 10: (12 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Alan Donovan: Patch Set 10: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
This PR (HEAD: 42b4a00) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
This PR (HEAD: e10b65f) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from xxx Lulu: Patch Set 10: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
dbb42a8
to
302c11d
Compare
This PR (HEAD: 302c11d) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from Go LUCI: Patch Set 14: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Robert Findley: Patch Set 14: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
This PR (HEAD: 8bde036) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from xxx Lulu: Patch Set 14: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from xxx Lulu: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Alan Donovan: Patch Set 15: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Go LUCI: Patch Set 15: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-28T18:21:16Z","revision":"4380b1531cbdab83d721b793de2df1eafe16aeee"} Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Alan Donovan: Patch Set 15: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Go LUCI: Patch Set 15: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-arm64-boringcrypto has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Go LUCI: Patch Set 15: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Alan Donovan: Patch Set 15: Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Go LUCI: Patch Set 15: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-28T18:32:01Z","revision":"4380b1531cbdab83d721b793de2df1eafe16aeee"} Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Alan Donovan: Patch Set 15: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Go LUCI: Patch Set 15: This CL has failed the run. Reason: Tryjob golang/try/x_tools-gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
… constructor of each symbol These new semantic type modifiers will report in type definition, type embedding, type alias, variable definition like `var foo Bar`'s `Bar', parameter type and return type
This PR (HEAD: f825f8a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/608156. Important tips:
|
Message from xxx Lulu: Patch Set 15: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Robert Findley: Patch Set 16: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
Message from Go LUCI: Patch Set 16: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-08-28T20:25:38Z","revision":"2aa017935c1d1c9e910d1e5d01caa142cc47285c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/608156. |
These new semantic type modifiers will be reported in places of type definition, type embedding, type alias, variable definition, parameter type, return type and comments link. Fixes golang/go#68975 Change-Id: I21ebd758351ee4c6e7bd7a0d34a093b3a6ad4ac8 GitHub-Last-Rev: f825f8a GitHub-Pull-Request: #511 Reviewed-on: https://go-review.googlesource.com/c/tools/+/608156 Reviewed-by: Alan Donovan <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Robert Findley <[email protected]> Auto-Submit: Robert Findley <[email protected]>
This PR is being closed because golang.org/cl/608156 has been merged. |
These new semantic type modifiers will be reported in places of type definition,
type embedding, type alias, variable definition, parameter type,
return type and comments link.
Fixes golang/go#68975