Skip to content

x/tools/gopls: fix rename command line fail #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

x/tools/gopls: fix rename command line fail #525

wants to merge 3 commits into from

Conversation

yincongcyincong
Copy link

@yincongcyincong yincongcyincong commented Sep 24, 2024 •
edited
Loading

Fixes golang/go#69582

if the path is not a file, there is a error will occur. because rename need file content , and then change it.
https://github.com/golang/tools/blob/master/gopls/internal/cmd/cmd.go#L777

this is the result of fixed.

/Users/yincong/Library/Caches/JetBrains/GoLand2024.1/tmp/GoLand/___go_build_golang_org_x_tools_gopls rename -diff ./internal/a/a.go:#9 b
--- /Users/yincong/go/src/github.com/yincongcyincong/tools/gopls/internal/a/a.go.orig
+++ /Users/yincong/go/src/github.com/yincongcyincong/tools/gopls/internal/a/a.go
@@ -1 +1 @@
-package a
+package b
--- /Users/yincong/go/src/github.com/yincongcyincong/tools/gopls/internal/b/a.go.orig
+++ /Users/yincong/go/src/github.com/yincongcyincong/tools/gopls/internal/b/a.go
@@ -0,0 +1 @@
+package a
--- /Users/yincong/go/src/github.com/yincongcyincong/tools/gopls/internal/a/a.go.orig
+++ /Users/yincong/go/src/github.com/yincongcyincong/tools/gopls/internal/a/a.go
@@ -1 +0,0 @@
-package a

@gopherbot
Copy link
Contributor

This PR (HEAD: 2025ede) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/615375.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@yincongcyincong yincongcyincong changed the title fix rename command line fail x/tools/gopls: fix rename command line fail Sep 24, 2024
@gopherbot
Copy link
Contributor

Message from qiu laidongfeng2:

Patch Set 2: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-09-24T13:43:36Z","revision":"f62db426bb9f3f6461f2e560291aa5ba49109986"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from qiu laidongfeng2:

Patch Set 2: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-go1.21-linux-amd64 has failed with summary (view all results):

Build or test failure, click here for results.

To reproduce, try gomote repro 8735908536077896785.

Additional links for debugging:

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Go LUCI:

Patch Set 2: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 2:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: 5e05fb0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/615375.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

This PR (HEAD: 82a2ef2) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/615375.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Robert Findley:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 4:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from cong yin:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/615375.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x/tools/gopls: rename package decl fails in CLI
2 participants
@yincongcyincong @gopherbot