-
Notifications
You must be signed in to change notification settings - Fork 2.3k
present: document shebang and txtar for .play #588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 7f76053) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/695356. Important tips:
|
7f76053
to
3dcbeb7
Compare
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/695356. |
This PR (HEAD: 3dcbeb7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/695356. Important tips:
|
The "play" command for present does not only support Go code, which was implicitly documented, but also generic scripts identified by a shebang or txtar-encoded input - enabling Go modules. The locally used implementation for "play" resides in ./playground/socket/socket.go. Mostly undocumented, this code first checks the input for a shebang and, if present, executes input with the shebang interpreter. This code also allows txtar-encoded input, which can be used to "play" Go modules, including external dependencies. Documenting the actual behavior helps users to understand and use the software better. Personally, I initially wanted to patch Go module support in present, just to find out everything is already there - just undocumented.
3dcbeb7
to
10dcaf4
Compare
This PR (HEAD: 10dcaf4) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/695356. Important tips:
|
The "play" command for present does not only support Go code, which was
implicitly documented, but also generic scripts identified by a shebang
or txtar-encoded input - enabling Go modules.
The locally used implementation for "play" resides in
./playground/socket/socket.go. Mostly undocumented, this code first
checks the input for a shebang and, if present, executes input with the
shebang interpreter. This code also allows txtar-encoded input, which
can be used to "play" Go modules, including external dependencies.
Documenting the actual behavior helps users to understand and use the
software better. Personally, I initially wanted to patch Go module
support in present, just to find out everything is already there - just
undocumented.