Skip to content

x/tools/gopls: CodeAction: do not offer "inline variable" on an lvalue reference #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

x/tools/gopls: CodeAction: do not offer "inline variable" on an lvalue reference #590

wants to merge 8 commits into from
+261 −29

Conversation

IlyasYOY
Copy link

@IlyasYOY IlyasYOY commented Sep 4, 2025

Fix for: golang/go#75200

@IlyasYOY
test(inline): add marker for inline‑LHS variable failure test
7c2cfa9 
Add a marker testdata file that checks that inlining a variable on the left-hand side of an assignment fails as expected.
@IlyasYOY
test(marker): add noCodeActionMarker helper and refactor codeActionCh…
6aa5089 
…anges logic

Introduce a new helper `noCodeActionMarker` that verifies the absence of code actions. Refactor the test logic in `codeActionChanges` to delegate to a shared `getActionsWithCandidates` function, simplifying the test code and reducing duplication.
@IlyasYOY
refactor: simplify canInlineVariable implementation
9662efe 
Added fix (golang/go#75200) in comments to
reproduce the error.
@IlyasYOY
fix(golang/inline): correctly skip left‑hand side assignments when in…
4f937fd 
…lining

Re‑enable the check that prevents inlining identifiers that are on the left‑hand side of an assignment. The previous implementation was commented out, which caused the inliner to occasionally incorrectly inline such identifiers. This patch restores the logic, ensuring the inlining logic does not erroneously modify assignment targets.

No breaking changes.

Fixes: golang/go#75200
@gopherbot
Copy link
Contributor

This PR (HEAD: 4f937fd) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/701035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Alan Donovan:

Patch Set 1:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/701035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR (HEAD: b004dd4) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Ilya Ilyinykh:

Patch Set 1:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/701035.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Ilya Ilyinykh:

Patch Set 2:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/701035.
After addressing review feedback, remember to publish your drafts!

@IlyasYOY
refactor: add safety checks for variable inlining
bb25652 
The inlining logic for variables now uses `isSafelyInlinable` to guard against unsafe replacements such as:
- the left‑hand side of an assignment or compound assignment
- increment/decrement operations
- taking the address of the variable
- calling a method with a pointer receiver

New helper functions `isCallingPtrRecvMethod` and `isTakingTheAddress` support these checks. Several tests were added to confirm that such cases do not produce a code action.

Fixes #75200
@gopherbot
Copy link
Contributor

This PR (HEAD: bb25652) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Ilya Ilyinykh:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/701035.
After addressing review feedback, remember to publish your drafts!

@IlyasYOY
refactor: improve inlining safety checks and add pointer receiver test
8ad209e 
- Updated `isSafelyInlinable` to correctly handle receiver method calls
- Added `isCallingRecvMethod` helper with `wantPtr` flag instead of separate functions
- Updated lexer logic for ParentEdge handling
- Added new marker test for inlining variable used on LHS with pointer receiver method
@gopherbot
Copy link
Contributor

This PR (HEAD: 8ad209e) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/701035.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link
Contributor

Message from Ilya Ilyinykh:

Patch Set 3:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/701035.
After addressing review feedback, remember to publish your drafts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IlyasYOY @gopherbot