gopls: expand multi-value returns in function extraction#616
gopls: expand multi-value returns in function extraction#616fatanugraha wants to merge 2 commits intogolang:masterfrom
Conversation
|
This PR (HEAD: 55b8fae) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/737560. Important tips:
|
75bc3ae to
e50d3ec
Compare
|
This PR (HEAD: e50d3ec) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/737560. Important tips:
|
|
Message from Madeline Kalil: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2026-01-20T18:32:36Z","revision":"f50b203a08bfb3bdf811a4e739851fa7d4f4a6c2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Madeline Kalil: Patch Set 2: -Commit-Queue (Posted by golang-scoped@luci-project-accounts.iam.gserviceaccount.com on behalf of mkalil@google.com) Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Madeline Kalil: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
This PR (HEAD: ab1f0bd) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/737560. Important tips:
|
|
Message from Gopher Robot: Patch Set 3: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
When extracting a function, handle return statements containing multi-value function calls by expanding them into variable assignments. This ensures valid syntax when the extracted function adds additional return values. Fixes golang/go#77240
|
This PR (HEAD: a315bfc) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/tools/+/737560. Important tips:
|
|
Message from Fata Nugraha: Patch Set 3: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Fata Nugraha: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
|
Message from Fata Nugraha: Patch Set 4: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/737560. |
When extracting a function, handle return statements containing
multi-value function calls by expanding them into variable
assignments. This ensures valid syntax when the extracted function
adds additional return values.
Fixes golang/go#77240