When we add a new setting in gopls whose type is unsupported in the vscode settings generation script (extension/tools/goplssetting/goplssetting.go), there is a conflict in the builders when releasing gopls.
The vscode builder attempts to use the latest released or preview version of gopls, which would be the pre-release (e.g. v0.22.0-pre.1) when we are releasing gopls. (See the pickLatest logic in extension/tools/installtools/main.go)
If we create a gopls pre-release with a new setting before we update the vscode settings generation script to handle that setting, the builder that uses the latest gopls version will fail.
We should consider switching the logic in installtools/main.go to not use pre-release versions of gopls and instead use the latest released version. This is the preferPreview setting in installtools/main.go.
This issue first occurred when attempting to add the maxFileCacheBytes setting to gopls, and the generation script did not handle parsing of int settings.
When we add a new setting in gopls whose type is unsupported in the vscode settings generation script (extension/tools/goplssetting/goplssetting.go), there is a conflict in the builders when releasing gopls.
The vscode builder attempts to use the latest released or preview version of gopls, which would be the pre-release (e.g. v0.22.0-pre.1) when we are releasing gopls. (See the pickLatest logic in extension/tools/installtools/main.go)
If we create a gopls pre-release with a new setting before we update the vscode settings generation script to handle that setting, the builder that uses the latest gopls version will fail.
We should consider switching the logic in installtools/main.go to not use pre-release versions of gopls and instead use the latest released version. This is the preferPreview setting in installtools/main.go.
This issue first occurred when attempting to add the maxFileCacheBytes setting to gopls, and the generation script did not handle parsing of int settings.