-
Notifications
You must be signed in to change notification settings - Fork 797
github/workflow: daily release workflow #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR (HEAD: 46d60d2e982f5853b208028a10d4a120201f2b15) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223677 to see it. Tip: You can toggle comments from me using the |
Message from Hyang-Ah Hana Kim: Patch Set 1: Adding Filippo to double check how we use our token. Please don’t reply on this GitHub thread. Visit golang.org/cl/223677. |
Message from Rebecca Stambler: Patch Set 1: Code-Review+1 LGTM, but I'll let Filippo +2. Please don’t reply on this GitHub thread. Visit golang.org/cl/223677. |
Message from Tyler Bui-Palsulich: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/223677. |
Daily release workflow is triggered everyday between Mon-Thu, 15:00 UTC (11am EDT). This prepares the version string through local modification on package.json and runs the tests again before publishing. The newly released version has the version string computed based on the last git commit's commit timestamp. <Year>.<Month>.<Day>-<Short Commit Hash> That means, if there is no commit since the last release, the publishing step will fail (because the MS VS Code extension market will detect the identical version).
This PR (HEAD: b7dc18b050e7a6f855ec14b6556deacb0fd1e4e0) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223677 to see it. Tip: You can toggle comments from me using the |
- remove extra white spaces - remove orphaned reference of matrix - make it use VS Code Insiders for testing
This PR (HEAD: b888148) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/223677 to see it. Tip: You can toggle comments from me using the |
Message from Hyang-Ah Hana Kim: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/223677. |
Message from Tyler Bui-Palsulich: Patch Set 4: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/223677. |
Daily release workflow is triggered everyday between Mon-Thu, 15:00 UTC (11am EDT). This prepares the version string through local modification on package.json and runs the tests again before publishing. The newly released version has the version string computed based on the last git commit's commit timestamp. <Year>.<Month>.<Day>-<Short Commit Hash> That means, if there is no commit since the last release, the publishing step will fail (because the MS VS Code extension market will detect the identical version). Update #5 Change-Id: Ief59f5ed4e89eea66df3607f20263c3f6b75e716 GitHub-Last-Rev: b888148 GitHub-Pull-Request: #10 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/223677 Reviewed-by: Tyler Bui-Palsulich <[email protected]>
This PR is being closed because golang.org/cl/223677 has been merged. |
Daily release workflow is triggered everyday between Mon-Thu, 15:00 UTC (11am EDT).
This prepares the version string through local modification on package.json
and runs the tests again before publishing. The newly released version has the
version string computed based on the last git commit's commit timestamp.
..-
That means, if there is no commit since the last release, the publishing step
will fail (because the MS VS Code extension market will detect the identical version).
Update #5