package.json: make additionalProperties false for object type settings#284
package.json: make additionalProperties false for object type settings#2849at8 wants to merge 1 commit into
additionalProperties false for object type settings#284Conversation
I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `"additionalProperties": false` for the objects that don't expect more properties would be great!
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
This PR (HEAD: 695aa78) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/vscode-go/+/240907 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/240907. |
|
Message from Hyang-Ah Hana Kim: Patch Set 1: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/240907. |
|
Message from Aditya Thakral: Patch Set 1: (6 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/240907. |
additionalProperties false for object type settingsadditionalProperties false for object type settings
|
Message from Hyang-Ah Hana Kim: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/240907. |
When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting `additionalProperties` to `false` for the objects that don't expect more properties would be great! As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if `additionalProperties` is `false` and all known properties are present. Change-Id: I92380610b24f7cd6ee790f2e020b9c689c3ff25b GitHub-Last-Rev: 695aa78 GitHub-Pull-Request: #284 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/240907 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
|
Message from Hyang-Ah Hana Kim: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/240907. |
|
This PR is being closed because golang.org/cl/240907 has been merged. |
In #284, we started to use additionalProperties to support vscode's new setting UI feature available for object type settings if the settings accept only predefined properties. "go.alternateTools" can accept more tool names than those specified in package.json. So, correct its additionalProperties value. Fixes #526 Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619 Reviewed-by: Suzy Mueller <suzmue@golang.org>
In #284, we started to use additionalProperties to support vscode's new setting UI feature available for object type settings if the settings accept only predefined properties. "go.alternateTools" can accept more tool names than those specified in package.json. So, correct its additionalProperties value. Fixes #526 Change-Id: I72d2a7e72702d13bc74ed72a34a93756569bb041 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/248619 Reviewed-by: Suzy Mueller <suzmue@golang.org> (cherry picked from commit e1603dd) Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/252120 Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: kokoro <noreply+kokoro@google.com>
When I'm working on making simple non-nested object type settings editable from the settings GUI in vscode (microsoft/vscode#99635), and I think that setting
additionalPropertiestofalsefor the objects that don't expect more properties would be great!As per microsoft/vscode#101810, vscode (v1.48) will hide the "Add item" button if and only if
additionalPropertiesisfalseand all known properties are present.