Skip to content

_content/doc/go1.20: add release note for new cookie.valid behavior #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

wfernandes
Copy link

@wfernandes wfernandes commented Feb 16, 2023

Fixes #58485

Add a release note documenting that Cookie.Valid ignores the
Cookie.Expires field when empty.

@gopherbot
Copy link
Contributor

This PR (HEAD: f00669a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/468716 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 1:

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/468716.
After addressing review feedback, remember to publish your drafts!

Fixes golang/go#58485

Add a release note documenting that Cookie.Valid ignores the
Cookie.Expires field when empty.

Signed-off-by: Warren Fernandes <[email protected]>
@wfernandes wfernandes force-pushed the cookie-validation-release-note branch from f00669a to 6355670 Compare February 17, 2023 04:56
@gopherbot
Copy link
Contributor

This PR (HEAD: 6355670) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/website/+/468716 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

Message from Warren Fernandes:

Patch Set 2:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/468716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 3: Auto-Submit+1 Run-TryBot+1

(4 comments)


Please don’t reply on this GitHub thread. Visit golang.org/cl/468716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Damien Neil:

Patch Set 3: Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/468716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3:

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/468716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

Message from Gopher Robot:

Patch Set 3: TryBot-Result+1

(1 comment)


Please don’t reply on this GitHub thread. Visit golang.org/cl/468716.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

This PR is being closed because golang.org/cl/468716 has been merged.

@gopherbot gopherbot closed this Feb 22, 2023
crisman pushed a commit to crisman/golang_website that referenced this pull request Feb 22, 2023
Fixes #58485

Add a release note documenting that Cookie.Valid ignores the
Cookie.Expires field when empty.

Change-Id: Ia0138dc2252c309c36ff774e30e4aa9a874bf1e5
GitHub-Last-Rev: 6355670
GitHub-Pull-Request: golang#193
Reviewed-on: https://go-review.googlesource.com/c/website/+/468716
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Damien Neil <[email protected]>
Auto-Submit: Damien Neil <[email protected]>
Reviewed-by: Damien Neil <[email protected]>
Reviewed-by: Bryan Mills <[email protected]>
@wfernandes wfernandes deleted the cookie-validation-release-note branch February 23, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants